Bug 261823 - REGRESSION(268124@main): Caused flaky crashes and text failures on svg/css/rect-system-color.xhtml
Summary: REGRESSION(268124@main): Caused flaky crashes and text failures on svg/css/re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 245609
  Show dependency treegraph
 
Reported: 2023-09-20 08:41 PDT by WebKit Commit Bot
Modified: 2023-09-20 08:48 PDT (History)
3 users (show)

See Also:


Attachments
REVERT of 268124@main (36.26 KB, patch)
2023-09-20 08:41 PDT, WebKit Commit Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2023-09-20 08:41:06 PDT
https://commits.webkit.org/268124@main introduced a regression:
Caused flaky crashes and text failures on svg/css/rect-system-color.xhtml

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2023-09-20 08:41:12 PDT
Created attachment 467788 [details]
REVERT of 268124@main

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 3 Aditya Keerthi 2023-09-20 08:42:50 PDT
ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
/Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/HashTable.h(648) : void WTF::HashTable<WebCore::Color, WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue>>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue>>>, WTF::DefaultHash<WebCore::Color>, WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue>>::KeyValuePairTraits, WTF::HashTraits<WebCore::Color>>::checkKey(const T &) [Key = WebCore::Color, Value = WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue>>, Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue>>>, HashFunctions = WTF::DefaultHash<WebCore::Color>, Traits = WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue>>::KeyValuePairTraits, KeyTraits = WTF::HashTraits<WebCore::Color>, HashTranslator = WTF::HashMapEnsureTranslator<WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue>>::KeyValuePairTraits, WTF::DefaultHash<WebCore::Color>>, T = WebCore::Color]
1   0x1270db469 WTFCrash
2   0x1897abbcb WTFCrashWithInfo(int, char const*, char const*, int)
3   0x18d315f5a void WTF::HashTable<WebCore::Color, WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > > >, WTF::DefaultHash<WebCore::Color>, WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::Color> >::checkKey<WTF::HashMapEnsureTranslator<WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::DefaultHash<WebCore::Color> >, WebCore::Color>(WebCore::Color const&)
4   0x18d315c20 WTF::HashTableAddResult<WTF::HashTableIterator<WTF::HashTable<WebCore::Color, WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > > >, WTF::DefaultHash<WebCore::Color>, WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::Color> >, WebCore::Color, WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > > >, WTF::DefaultHash<WebCore::Color>, WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::Color> > > WTF::HashTable<WebCore::Color, WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > > >, WTF::DefaultHash<WebCore::Color>, WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::Color> >::add<WTF::HashMapEnsureTranslator<WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::DefaultHash<WebCore::Color> >, WebCore::Color const&, WebCore::CSSValuePool::createColorValue(WebCore::Color const&)::$_1>(WebCore::Color const&, WebCore::CSSValuePool::createColorValue(WebCore::Color const&)::$_1&&)
5   0x18d315bc5 WTF::HashTableAddResult<WTF::HashTableIterator<WTF::HashTable<WebCore::Color, WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > > >, WTF::DefaultHash<WebCore::Color>, WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::Color> >, WebCore::Color, WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > > >, WTF::DefaultHash<WebCore::Color>, WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::Color> > > WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::inlineEnsure<WebCore::Color const&, WebCore::CSSValuePool::createColorValue(WebCore::Color const&)::$_1>(WebCore::Color const&, WebCore::CSSValuePool::createColorValue(WebCore::Color const&)::$_1&&)
6   0x18d2d6db0 WTF::HashTableAddResult<WTF::HashTableIterator<WTF::HashTable<WebCore::Color, WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > > >, WTF::DefaultHash<WebCore::Color>, WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::Color> >, WebCore::Color, WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > > >, WTF::DefaultHash<WebCore::Color>, WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::Color> > > WTF::HashMap<WebCore::Color, WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> >, WTF::DefaultHash<WebCore::Color>, WTF::HashTraits<WebCore::Color>, WTF::HashTraits<WTF::Ref<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue> > >, WTF::HashTableTraits>::ensure<WebCore::CSSValuePool::createColorValue(WebCore::Color const&)::$_1>(WebCore::Color const&, WebCore::CSSValuePool::createColorValue(WebCore::Color const&)::$_1&&)
7   0x18d2d6bea WebCore::CSSValuePool::createColorValue(WebCore::Color const&)
8   0x18d39341d WebCore::ComputedStyleExtractor::svgPropertyValue(WebCore::CSSPropertyID) const::$_2::operator()(WebCore::StyleColor const&) const
9   0x18d392961 WebCore::ComputedStyleExtractor::svgPropertyValue(WebCore::CSSPropertyID) const
10  0x18d2eb611 WebCore::ComputedStyleExtractor::valueForPropertyInStyle(WebCore::RenderStyle const&, WebCore::CSSPropertyID, WebCore::RenderElement*, WebCore::ComputedStyleExtractor::PropertyValueType) const
11  0x18d2deae8 WebCore::ComputedStyleExtractor::propertyValue(WebCore::CSSPropertyID, WebCore::ComputedStyleExtractor::UpdateLayout, WebCore::ComputedStyleExtractor::PropertyValueType) const
12  0x18d153760 WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue(WebCore::CSSPropertyID, WebCore::ComputedStyleExtractor::UpdateLayout) const
13  0x18d15390d WebCore::CSSComputedStyleDeclaration::getPropertyValue(WebCore::CSSPropertyID) const
14  0x18d15435e WebCore::CSSComputedStyleDeclaration::getPropertyValueInternal(WebCore::CSSPropertyID)
15  0x18d27ccff WebCore::CSSStyleDeclaration::propertyValueForCamelCasedIDLAttribute(WTF::AtomString const&)
16  0x18a1bfe30 WebCore::jsCSSStyleDeclaration_propertyValueForCamelCasedIDLAttributeGetter(JSC::JSGlobalObject&, WebCore::JSCSSStyleDeclaration&, JSC::PropertyName)
17  0x18a0ffcde long long WebCore::IDLAttribute<WebCore::JSCSSStyleDeclaration>::getPassingPropertyName<&(WebCore::jsCSSStyleDeclaration_propertyValueForCamelCasedIDLAttributeGetter(JSC::JSGlobalObject&, WebCore::JSCSSStyleDeclaration&, JSC::PropertyName)), (WebCore::CastedThisErrorBehavior)3>(JSC::JSGlobalObject&, long long, JSC::PropertyName)
18  0x18a0ffb7d WebCore::jsCSSStyleDeclaration_propertyValueForCamelCasedIDLAttribute(JSC::JSGlobalObject*, long long, JSC::PropertyName)
19  0x128ffbb6b WTF::FunctionPtr<(WTF::PtrTag)57072, long long (JSC::JSGlobalObject*, long long, JSC::PropertyName), (WTF::FunctionAttributes)1>::operator()(JSC::JSGlobalObject*, long long, JSC::PropertyName) const
20  0x129287422 JSC::PropertySlot::customGetter(JSC::VM&, JSC::PropertyName) const
21  0x128dc4866 JSC::PropertySlot::getValue(JSC::JSGlobalObject*, JSC::PropertyName) const
22  0x128dd38dd JSC::JSValue::get(JSC::JSGlobalObject*, JSC::PropertyName, JSC::PropertySlot&) const
23  0x128ced2b4 JSC::LLInt::performLLIntGetByID(JSC::BytecodeIndex, JSC::CodeBlock*, JSC::JSGlobalObject*, JSC::JSValue, JSC::Identifier const&, JSC::GetByIdModeMetadata&)
24  0x128ced05f llint_slow_path_get_by_id
25  0x1278aa1bd llint_entry
26  0x12789e51f vmEntryToJavaScript
27  0x128b1e93c JSC::Interpreter::executeEval(JSC::EvalExecutable*, JSC::JSValue, JSC::JSScope*)
28  0x128b1d346 JSC::eval(JSC::CallFrame*, JSC::JSValue, JSC::JSScope*, JSC::ECMAMode)
29  0x128c14945 operationCallDirectEvalSloppy
30  0x58621bb023e6 29  ???                                 0x000058621bb023e6 0x0 + 97178394567654
31  0x1278c3c89 llint_entry
Comment 4 EWS 2023-09-20 08:47:47 PDT
Committed 268201@main (9a3fdcd1f924): <https://commits.webkit.org/268201@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467788 [details].
Comment 5 Radar WebKit Bug Importer 2023-09-20 08:48:13 PDT
<rdar://problem/115786393>