Bug 26177 - Add Chromium-specific constructors to Platform event classes.
Summary: Add Chromium-specific constructors to Platform event classes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dmitry Titov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-03 16:12 PDT by Dmitry Titov
Modified: 2009-06-03 17:08 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (2.22 KB, patch)
2009-06-03 16:13 PDT, Dmitry Titov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-06-03 16:12:11 PDT
That fixes the build break caused by change of 'protected' data members to 'private' in PlatformMouseEvent and PlatformWheelEvent. Also it makes it possible to remove MakePlatformMouseEvent and MakePlatformWheelEvent in Chromium glue.
Comment 1 Dmitry Titov 2009-06-03 16:13:48 PDT
Created attachment 30931 [details]
Proposed patch
Comment 2 Dimitri Glazkov (Google) 2009-06-03 16:27:43 PDT
Let's just turn private back into protected here.
Comment 3 Sam Weinig 2009-06-03 16:45:40 PDT
It seems like a gratuitous layering violation to have WebKit level classes referenced from WebCore.
Comment 4 Dimitri Glazkov (Google) 2009-06-03 16:49:45 PDT
(In reply to comment #3)
> It seems like a gratuitous layering violation to have WebKit level classes
> referenced from WebCore.
> 

yup.
Comment 5 Dmitry Titov 2009-06-03 16:58:16 PDT
Comment on attachment 30931 [details]
Proposed patch

Removing r? Yep, that is layering violation. Will just change 'private' back to 'protected'. The better solution can come from integrating Chromium glue into WebKit tree.
Comment 6 Dmitry Titov 2009-06-03 17:08:33 PDT
Change to 'protected' landed as a build fix: http://trac.webkit.org/changeset/44404