261760 – Websites Crashing/Reloading in STP 178

Bug 261760 - Websites Crashing/Reloading in STP 178

Summary: Websites Crashing/Reloading in STP 178

Status:	RESOLVED DUPLICATE of bug 261421

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	Safari Technology Preview
Hardware:	Mac (Apple Silicon) Other

Importance:	P2 Major
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2023-09-19 11:15 PDT by Jack Wellborn
Modified:	2023-09-25 11:45 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Demonstration of Ars Technica Crashing/Reloading (119.69 MB, video/quicktime) 2023-09-19 11:15 PDT, Jack Wellborn	no flags	Details
Webkit WebContent Crash Report (56.55 KB, text/plain) 2023-09-20 04:48 PDT, Jack Wellborn	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jack Wellborn 2023-09-19 11:15:51 PDT

Created attachment 467761 [details]
Demonstration of Ars Technica Crashing/Reloading

Hello, 

Some of the sites I commonly frequent seem to crash in Safari Technology Preview 178, most notably https://arstechnica.com/. This occurs even in a Private Browsing window. 

Environment:
MacBook Pro with M1 Pro
macOS Sonoma 14.0 (23A339)
Safari Technology Preview 178

Comment 1 Ahmad Saleem 2023-09-19 12:18:22 PDT

Can you attach 'Crash Logs' from Console.app?

I am unable to reproduce the bug on macOS Ventura with STP178 and it does not crash. I do have ad blocker and other extensions though.

Comment 2 Jack Wellborn 2023-09-19 12:58:09 PDT

Weird. I also experienced the issue on https://www.washingtonpost.com earlier today, but I am not reproducing on either site now. My guess is some common bit of ad tech was causing the issue. I will close and reopen if it rears its ugly head again.

Comment 3 Jack Wellborn 2023-09-20 04:48:35 PDT

Created attachment 467785 [details]
Webkit WebContent Crash Report

This is the request Crash Report.

Comment 4 Jack Wellborn 2023-09-20 04:49:16 PDT

Issue started happening again on washingtonpost.com and I have attached the crash report.

Comment 5 Sam Sneddon [:gsnedders] 2023-09-20 07:46:03 PDT

Crashing in WebCore::ShorthandSerializer::serializeGridTemplate, which Sammy recently touched in Bug 260494.

rdar://115783828

Comment 6 Sammy Gill 2023-09-20 13:28:37 PDT

Thanks for the report! Given the crash signature, I think there is a decent chance that this is a dupe of https://bugs.webkit.org/show_bug.cgi?id=261421 and that patch may fix the issue. Is there a way to reproduce the issue reliably? That would help us determine if this truly is a dupe because I have not been able to reproduce it on either of the sites yet

Comment 7 Jack Wellborn 2023-09-21 06:05:40 PDT

Unfortunately, I can't reproduce easily as I suspect the offending code is coming from some ad tech on sites. That said, I also strongly suspect it might be the same `element.TextContent = ""` behavior from the linked issue as that is exactly the kind of thing an ad related script might do. I am going to see if I can reproduce before updating to 179, then see if I can reproduce after.

Comment 8 Sammy Gill 2023-09-21 09:36:19 PDT

If I'm reading the release notes correctly it seems like that the change might not have gotten picked up by STP yet :(

Comment 9 Sammy Gill 2023-09-25 11:45:40 PDT

I am going to mark this as a duplicate since I think that the underlying cause of the bug is the same. Once the fix gets into STP please try it again and reopen the bugzilla if the issue still reproduces!

*** This bug has been marked as a duplicate of bug 261421 ***