RESOLVED FIXED 261742
AX: Add AXCorObject.cpp and move methods implementation from AccessibilityObjectInterface.h. 
https://bugs.webkit.org/show_bug.cgi?id=261742
Summary AX: Add AXCorObject.cpp and move methods implementation from AccessibilityObj...
Andres Gonzalez
Reported 2023-09-19 07:41:17 PDT
.
Attachments
Patch (42.51 KB, patch)
2023-09-19 19:06 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (42.88 KB, patch)
2023-09-20 10:54 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (43.92 KB, patch)
2023-09-20 11:26 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (43.91 KB, patch)
2023-09-20 13:24 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-09-19 07:41:27 PDT
<rdar://problem/115725555>
Andres Gonzalez
Comment 2 2023-09-19 19:06:34 PDT
Created attachment 467774 [details] Patch
Andres Gonzalez
Comment 3 2023-09-20 10:54:39 PDT
Created attachment 467789 [details] Patch
Andres Gonzalez
Comment 4 2023-09-20 11:26:02 PDT
Created attachment 467790 [details] Patch
Tyler Wilcock
Comment 5 2023-09-20 13:05:23 PDT
Comment on attachment 467790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467790&action=review > Source/WebCore/accessibility/AXCoreObject.cpp:119 > + // These roles are containers whose children support aria-selected: Seems like this comment got indented an extra level as part of the move. > Source/WebCore/accessibility/AXCoreObject.cpp:128 > + // These roles are containers whose children are treated as selected by assistive > + // technologies. We can get the "selected" item via aria-activedescendant or the > + // focused element. Seems like this comment got indented an extra level as part of the move.
Andres Gonzalez
Comment 6 2023-09-20 13:24:23 PDT
Created attachment 467793 [details] Patch Fixed indentation of comments.
EWS
Comment 7 2023-09-20 14:55:22 PDT
Committed 268217@main (bcba489ee356): <https://commits.webkit.org/268217@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467793 [details].
Note You need to log in before you can comment on or make changes to this bug.