Bug 261737 - [GStreamer] Instantiate downloadbuffer element with playbin3 if video preload="auto"
Summary: [GStreamer] Instantiate downloadbuffer element with playbin3 if video preload...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-19 06:33 PDT by Marek Vasut
Modified: 2023-09-22 15:14 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Vasut 2023-09-19 06:33:33 PDT 
When using WEBKIT_GST_USE_PLAYBIN3=1 and cog to open website with content
<video src="./test.mp4" preload="auto" autoplay="autoplay" loop></video>
the video would not be buffered into on-disk cache as it used to be with
playbin(2). This is because playbin3 uridecodebin instantiated urisourcebin
does not instantiate downloadbuffer element by default, this has to be
explicitly enabled by setting the urisourcebin element 'download' parameter
to TRUE.
Comment 1 Marek Vasut 2023-09-19 07:23:26 PDT 
Pull Request: https://github.com/WebKit/WebKit/pull/17915
Comment 2 EWS 2023-09-22 15:13:30 PDT 
Committed 268335@main (5d7c777b2c94): <https://commits.webkit.org/268335@main>

Reviewed commits have been landed. Closing PR #17915 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-22 15:14:19 PDT 
<rdar://problem/115911820>