Bug 26172 - v8's ScriptController::evaluate should protect the Frame like the jsc version.
Summary: v8's ScriptController::evaluate should protect the Frame like the jsc version.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-03 13:15 PDT by David Levin
Modified: 2009-06-03 13:33 PDT (History)
1 user (show)

See Also:


Attachments
Proposed fix. (1.71 KB, patch)
2009-06-03 13:24 PDT, David Levin
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-06-03 13:15:33 PDT
jsc;s ScriptController added refs to the Frame to protect it during certain javascript calls in the following changes:
* http://trac.webkit.org/changeset/42409
* http://trac.webkit.org/changeset/42417

v8's version should have the same ref count protections to avoid similar crashes.
Comment 1 David Levin 2009-06-03 13:24:03 PDT
Created attachment 30923 [details]
Proposed fix.
Comment 2 David Levin 2009-06-03 13:33:31 PDT
Committed as http://trac.webkit.org/changeset/44391