Bug 261630 - Avoid computing layer bounds in BackingSharingState::isAdditionalProviderCandidate()
Summary: Avoid computing layer bounds in BackingSharingState::isAdditionalProviderCand...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Compositing (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-15 19:50 PDT by Simon Fraser (smfr)
Modified: 2023-09-16 12:47 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-09-15 19:50:33 PDT 
The calls to calculateLayerBounds() in BackingSharingState::isAdditionalProviderCandidate() show as very hot on profiles on a page with many (thousands) of backing sharing candidates.

We have already computed layer bounds, so we can just use the ones we've computed in OverlapExtent.
Comment 1 Radar WebKit Bug Importer 2023-09-15 19:51:04 PDT 
<rdar://problem/115584910>
Comment 2 Simon Fraser (smfr) 2023-09-15 20:00:44 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17834
Comment 3 EWS 2023-09-16 12:47:57 PDT 
Committed 268056@main (9dcbb2227753): <https://commits.webkit.org/268056@main>

Reviewed commits have been landed. Closing PR #17834 and removing active labels.