Bug 26162 - With accelerated compositing, interrupted compound transform transition jumps around
: With accelerated compositing, interrupted compound transform transition jumps...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: CSS
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Chris Marrin
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-03 09:00 PDT by Chris Marrin
Modified: 2009-06-03 16:58 PDT (History)
0 users

See Also:


Attachments
Test case (1.27 KB, text/html)
2009-06-03 09:01 PDT, Chris Marrin
no flags Details
Patch (2.50 KB, patch)
2009-06-03 10:34 PDT, Chris Marrin
sam: review+
Details | Formatted Diff | Diff
Patch with test (5.15 KB, patch)
2009-06-03 15:44 PDT, Chris Marrin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2009-06-03 09:00:47 PDT
In the attached testcase, (with accelerated compositing enabled) a transition of a compound transform is interrupted. This causes the element to jump to an odd position.

From rdar://problem/6612047
Comment 1 Chris Marrin 2009-06-03 09:01:46 PDT
Created attachment 30908 [details]
Test case
Comment 2 Chris Marrin 2009-06-03 10:34:31 PDT
Created attachment 30912 [details]
Patch
Comment 3 Chris Marrin 2009-06-03 10:34:48 PDT
Added patch with the same fix as in the radar
Comment 4 Sam Weinig 2009-06-03 14:54:09 PDT
Comment on attachment 30912 [details]
Patch

>  {
> -    // Do the cleanup here instead of in the base class so the specialized methods get called
> +    // // Make sure to tell the renderer that we are ending. This will make sure any accelerated animations are removed.

Double comment!


r=me.
Comment 5 Chris Marrin 2009-06-03 15:44:03 PDT
Created attachment 30927 [details]
Patch with test

This replacement patch includes a manual test. Because of the nature of the animation bug, there's no way to make a meaningful layout test.
Comment 6 Simon Fraser (smfr) 2009-06-03 16:25:05 PDT
Comment on attachment 30927 [details]
Patch with test

> +<html lang="en">
> +<head>
> +  <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
> +  <title>Value Function Bug?</title>

Please fix the page title, and add a link to this bug.

r=me
Comment 7 Chris Marrin 2009-06-03 16:58:17 PDT
Sending        WebCore/ChangeLog
Adding         WebCore/manual-tests/interrupted-compound-transform.html
Sending        WebCore/page/animation/ImplicitAnimation.cpp
Sending        WebCore/page/animation/KeyframeAnimation.cpp
Transmitting file data ....
Committed revision 44403.