Bug 26160 - Compile fails in MacOSX when GNU fileutils are installed
Summary: Compile fails in MacOSX when GNU fileutils are installed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-03 07:35 PDT by Shinichiro Hamaji
Modified: 2009-06-05 15:29 PDT (History)
2 users (show)

See Also:


Attachments
Patch v1 (3.68 KB, patch)
2009-06-03 07:35 PDT, Shinichiro Hamaji
ap: review+
Details | Formatted Diff | Diff
Error log (50.38 KB, text/plain)
2009-06-03 07:36 PDT, Shinichiro Hamaji
no flags Details
Patch v2 (3.71 KB, patch)
2009-06-04 21:43 PDT, Shinichiro Hamaji
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2009-06-03 07:35:30 PDT
As GNU fileutils' ln command does not support -h option, the build fails if GNU fileutils is installed in my PATH (I'll attach the error log). Though we can avoid this compile failure by changing PATH, it would harm nothing to use Apple's ln command explicitly.
Comment 1 Shinichiro Hamaji 2009-06-03 07:35:58 PDT
Created attachment 30905 [details]
Patch v1

 JavaScriptCore/ChangeLog                           |    8 ++++++++
 .../JavaScriptCore.xcodeproj/project.pbxproj       |    2 +-
 WebCore/ChangeLog                                  |    8 ++++++++
 WebCore/WebCore.xcodeproj/project.pbxproj          |    2 +-
 4 files changed, 18 insertions(+), 2 deletions(-)
Comment 2 Shinichiro Hamaji 2009-06-03 07:36:36 PDT
Created attachment 30906 [details]
Error log
Comment 3 Alexey Proskuryakov 2009-06-04 03:44:05 PDT
Comment on attachment 30905 [details]
Patch v1

> +        Use /bin/ln instead of ln for cases where this command is used with -h option. As this option is not supported by GNU fileutils, this change helps users who have GNU fileutils in their PATH.

We usually try to make lines a bit shorter in ChangeLogs, unlike in source files.

r=me
Comment 4 Shinichiro Hamaji 2009-06-04 09:24:48 PDT
I see. I'll fix the length of lines in ChangeLog and upload another patch. Are there any recommended length? Maybe ~100Bytes seems to be the max length?
Comment 5 Shinichiro Hamaji 2009-06-04 21:43:32 PDT
Created attachment 30989 [details]
Patch v2

 JavaScriptCore/ChangeLog                           |   10 ++++++++++
 .../JavaScriptCore.xcodeproj/project.pbxproj       |    2 +-
 WebCore/ChangeLog                                  |   10 ++++++++++
 WebCore/WebCore.xcodeproj/project.pbxproj          |    2 +-
 4 files changed, 22 insertions(+), 2 deletions(-)
Comment 6 Shinichiro Hamaji 2009-06-04 21:43:54 PDT
Comment on attachment 30989 [details]
Patch v2

Added line breaks for ChangeLog.
Comment 7 David Kilzer (:ddkilzer) 2009-06-05 07:17:47 PDT
Comment on attachment 30989 [details]
Patch v2

A reference to this bug should also be included in the ChangeLog, but I'll do that when I land the patch.
Comment 8 David Kilzer (:ddkilzer) 2009-06-05 07:44:23 PDT
$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       JavaScriptCore/ChangeLog
        M       JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
        M       WebCore/ChangeLog
        M       WebCore/WebCore.xcodeproj/project.pbxproj
Committed r44470

http://trac.webkit.org/changeset/44470
Comment 9 Shinichiro Hamaji 2009-06-05 15:29:30 PDT
> A reference to this bug should also be included in the ChangeLog, but I'll do
> that when I land the patch.
Oops. Sorry for forgetting about the bug URL and thanks for landing this change!