As GNU fileutils' ln command does not support -h option, the build fails if GNU fileutils is installed in my PATH (I'll attach the error log). Though we can avoid this compile failure by changing PATH, it would harm nothing to use Apple's ln command explicitly.
Created attachment 30905 [details] Patch v1 JavaScriptCore/ChangeLog | 8 ++++++++ .../JavaScriptCore.xcodeproj/project.pbxproj | 2 +- WebCore/ChangeLog | 8 ++++++++ WebCore/WebCore.xcodeproj/project.pbxproj | 2 +- 4 files changed, 18 insertions(+), 2 deletions(-)
Created attachment 30906 [details] Error log
Comment on attachment 30905 [details] Patch v1 > + Use /bin/ln instead of ln for cases where this command is used with -h option. As this option is not supported by GNU fileutils, this change helps users who have GNU fileutils in their PATH. We usually try to make lines a bit shorter in ChangeLogs, unlike in source files. r=me
I see. I'll fix the length of lines in ChangeLog and upload another patch. Are there any recommended length? Maybe ~100Bytes seems to be the max length?
Created attachment 30989 [details] Patch v2 JavaScriptCore/ChangeLog | 10 ++++++++++ .../JavaScriptCore.xcodeproj/project.pbxproj | 2 +- WebCore/ChangeLog | 10 ++++++++++ WebCore/WebCore.xcodeproj/project.pbxproj | 2 +- 4 files changed, 22 insertions(+), 2 deletions(-)
Comment on attachment 30989 [details] Patch v2 Added line breaks for ChangeLog.
Comment on attachment 30989 [details] Patch v2 A reference to this bug should also be included in the ChangeLog, but I'll do that when I land the patch.
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M WebCore/ChangeLog M WebCore/WebCore.xcodeproj/project.pbxproj Committed r44470 http://trac.webkit.org/changeset/44470
> A reference to this bug should also be included in the ChangeLog, but I'll do > that when I land the patch. Oops. Sorry for forgetting about the bug URL and thanks for landing this change!