Bug 261471 - REGRESSION(267765@main) builtins-generator suite is failing with wrong copyright and outdated baseline
Summary: REGRESSION(267765@main) builtins-generator suite is failing with wrong copyri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-12 11:18 PDT by Lauro Moura
Modified: 2023-09-25 11:04 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2023-09-12 11:18:15 PDT 
Example of failed run from wpe builder: https://build.webkit.org/#/builders/40/builds/11923/steps/21/logs/stdio

Two issues:

- The copyright template in `builtins_templates.py` doesn't need the end year, which is added by `BuiltinsCollection.copyrights()` from `builtins_model.py`.
- The results needed to be updated with `--reset-results` to account for the new `JSC::SourceTaintedOrigin::Untainted` parameter.

Patch incoming
Comment 1 Lauro Moura 2023-09-12 11:21:03 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17698
Comment 2 Radar WebKit Bug Importer 2023-09-19 11:19:19 PDT 
<rdar://problem/115736986>
Comment 3 EWS 2023-09-25 11:04:49 PDT 
Committed 268401@main (e911779c50f0): <https://commits.webkit.org/268401@main>

Reviewed commits have been landed. Closing PR #17698 and removing active labels.