Bug 261415 - downcast() should return a smart pointer when passed in a smart pointer
Summary: downcast() should return a smart pointer when passed in a smart pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-11 10:01 PDT by Chris Dumez
Modified: 2023-09-12 15:38 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-09-11 10:01:06 PDT 
downcast() should return a smart pointer when passed in a smart pointer. Otherwise, it forces us to use the less-safe static_pointer_cast() / static_reference_cast() to cast without causing ref counting churn.
Comment 1 Chris Dumez 2023-09-11 10:09:44 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17655
Comment 2 EWS 2023-09-12 15:37:19 PDT 
Committed 267923@main (cea23dc5de28): <https://commits.webkit.org/267923@main>

Reviewed commits have been landed. Closing PR #17655 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-12 15:38:13 PDT 
<rdar://problem/115391755>