Bug 261402 - Calling configure on WebCodecs Video Encoder triggers a new key frame each time even if the configuration is only changing the bitrate
Summary: Calling configure on WebCodecs Video Encoder triggers a new key frame each ti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-11 03:46 PDT by youenn fablet
Modified: 2024-07-09 05:54 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2023-09-11 03:46:21 PDT 
We could try to change the model so that we pass the configure command up to the actual encoder, but it would somehow clash with the libwebrtc codec model.
A simpler approach is to make sure that if only bitrate is changing, we should not recreate the underlying compression session and send a change-bitrate message instead.
Comment 1 Radar WebKit Bug Importer 2023-09-14 02:39:16 PDT 
<rdar://problem/115482127>
Comment 2 youenn fablet 2023-12-08 04:36:42 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21499
Comment 3 EWS 2024-07-09 05:54:07 PDT 
Committed 280771@main (37dfb4fa3c73): <https://commits.webkit.org/280771@main>

Reviewed commits have been landed. Closing PR #21499 and removing active labels.