Bug 261378 - propagate scope element into :has CheckingContext
Summary: propagate scope element into :has CheckingContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-09 15:54 PDT by Cameron McCormack (:heycam)
Modified: 2023-09-11 01:21 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2023-09-09 15:54:16 PDT 
In https://bugs.webkit.org/show_bug.cgi?id=261320 we split out CheckingContext::scope into two separate fields: "scope" for the element that matches :scope, and "hasScope" for the scope of a :has() pseudo-class.

We need to propagate scope into the child CheckingContext we create for :has() pseudo-class matching, otherwise :has(:scope) will never match anything.
Comment 1 Cameron McCormack (:heycam) 2023-09-09 15:54:35 PDT 
rdar://106524140
Comment 2 Cameron McCormack (:heycam) 2023-09-09 15:56:45 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17629
Comment 3 EWS 2023-09-11 01:21:50 PDT 
Committed 267856@main (32c83e1e34db): <https://commits.webkit.org/267856@main>

Reviewed commits have been landed. Closing PR #17629 and removing active labels.