Bug 26136 - Update WinLauncher for WebKitCreateInstance
Summary: Update WinLauncher for WebKitCreateInstance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-02 10:01 PDT by Brent Fulgham
Modified: 2009-06-02 12:03 PDT (History)
0 users

See Also:

Attachments
Update Windows example for current WebKit techniques. (7.80 KB, patch)
2009-06-02 10:40 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Remove use of CoCreateInstance (2.38 KB, patch)
2009-06-02 11:05 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Switch from CoCreateInstance to WebKitCreateInstance (2.29 KB, patch)
2009-06-02 11:06 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Complete patch this time. (5.52 KB, patch)
2009-06-02 11:09 PDT, Brent Fulgham 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2009-06-02 10:01:34 PDT 
A very common problem when attempting to use WebKit is setting up proper link parameters (and manifest flags) so that the various WebKit objects are accessible via the CoCreateInstance infrastructure.  This was remedied by the creation of the WebKitCreateInstance method, which removes a lot of the guesswork in setting up and using WebKit.

This patch modifies the WinLauncher example program to use WebKitCreateInstance so that a good example of WebKit use is available for prospective users.
Comment 1 Brent Fulgham 2009-06-02 10:40:23 PDT 
Created attachment 30873 [details]
Update Windows example for current WebKit techniques.

A patch to make the WinLauncher program a better example for prospective Windows WebKit users.
Comment 2 Brent Fulgham 2009-06-02 11:05:05 PDT 
Created attachment 30874 [details]
Remove use of CoCreateInstance

Remove use of ATL CComPTR smart pointers, as they are not available in VS C++ Express.
Comment 3 Brent Fulgham 2009-06-02 11:06:43 PDT 
Created attachment 30875 [details]
Switch from CoCreateInstance to WebKitCreateInstance

Remove use of ATL-specific CComPTR smart pointer, since it is not available in VC++ Express.
Comment 4 Brent Fulgham 2009-06-02 11:09:42 PDT 
Created attachment 30876 [details]
Complete patch this time.

Remove use of ATL-only CComPTR, as it is not present in VC++ Express libraries.
Comment 5 Adam Roben (:aroben) 2009-06-02 11:12:20 PDT 
Comment on attachment 30876 [details]
Complete patch this time.

r=me
Comment 6 Brent Fulgham 2009-06-02 12:03:19 PDT 
Landed in @r44363.