Bug 26124 - resolve-ChangeLogs --continue hangs if git rebase --continue needs to launch $EDITOR
Summary: resolve-ChangeLogs --continue hangs if git rebase --continue needs to launch ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 21418
Blocks:
  Show dependency tree / graph
 
Reported: 2009-06-01 16:30 PDT by Eric Seidel (no email)
Modified: 2009-06-02 02:57 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-06-01 16:30:37 PDT 
resolve-ChangeLogs --continue hangs if git rebase --continue needs to launch $EDITOR

eseidel-mac [6520:WebKit]% resolve-ChangeLogs -c                               
                                        [~/Projects/WebKit]

M       WebCore/ChangeLog
Running 'git rebase --continue'...
Vim: Warning: Output is not to a terminal

And the terminal is hung. ;)

I'm not sure what the conditions under which it decides it needs to launch an editor are...
Comment 1 David Kilzer (:ddkilzer) 2009-06-01 20:34:54 PDT 
I suppose we should just "exec" git-rebase since it's essentially the last thing that's ever done if you enable that command-line switch.