RESOLVED FIXED 261235
Add a WKWebPushToolMain for webpushtool to use 
https://bugs.webkit.org/show_bug.cgi?id=261235
Summary Add a WKWebPushToolMain for webpushtool to use
Brady Eidson
Reported 2023-09-06 15:23:27 PDT
Upcoming work requires webpushtool code to properly be inside the WebKit build, so let's just have it work like our daemons do, with an exported WKMain function
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-09-06 15:23:41 PDT
<rdar://problem/115079480>
Brady Eidson
Comment 2 2023-09-06 15:26:32 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17507
EWS
Comment 3 2023-09-06 20:15:59 PDT
Committed 267714@main (a12bd8488608): <https://commits.webkit.org/267714@main> Reviewed commits have been landed. Closing PR #17507 and removing active labels.
youenn fablet
Comment 4 2023-09-07 06:01:19 PDT
This seems to break my command line build (USE_WORKSPACE=NO make r).
EWS
Comment 5 2023-09-07 08:28:20 PDT
Committed 267732@main (e0822d5cf7c5): <https://commits.webkit.org/267732@main> Reviewed commits have been landed. Closing PR #17544 and removing active labels.
Brady Eidson
Comment 6 2023-09-07 14:08:08 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/17553
Brady Eidson
Comment 7 2023-09-07 14:10:06 PDT
This broke production builds (And presumably the specific type of command line build Youenn did) because there were still some things left in the "webpushtool" target in the Xcode project. Clearing them out so it's just the .cpp that calls the new stub seems to have fixed it 👍
EWS
Comment 8 2023-09-07 15:44:46 PDT
Committed 267755@main (d222062cd5d9): <https://commits.webkit.org/267755@main> Reviewed commits have been landed. Closing PR #17553 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.