Bug 26123 - KURL::KURL() seems to have a redundant checkEncodedString call
Summary: KURL::KURL() seems to have a redundant checkEncodedString call
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-01 16:12 PDT by Jeremy Orlow
Modified: 2009-06-01 23:42 PDT (History)
1 user (show)

See Also:


Attachments
A patch that removes the redundant call. (899 bytes, patch)
2009-06-01 16:13 PDT, Jeremy Orlow
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-06-01 16:12:15 PDT
KURL::KURL() seems to have a redundant checkEncodedString() call since the first thing KURL::parse() does is run checkEncodedString().  Changing something like this seems scary, but it seemed worth submitting in case this really is an oversight.
Comment 1 Jeremy Orlow 2009-06-01 16:13:32 PDT
Created attachment 30843 [details]
A patch that removes the redundant call.
Comment 2 Jeremy Orlow 2009-06-01 18:43:14 PDT
I'm not a committer, so please land the patch for me?

Thanks!

P.S. I just noticed that checkEncodedString is only run in debug mode, so this patch probably isn't super critical.  If you want to mark this WONTFIX, I won't be offended.  :-)
Comment 3 Adam Barth 2009-06-01 23:35:33 PDT
Will land.
Comment 4 Adam Barth 2009-06-01 23:42:17 PDT
Sending        WebCore/ChangeLog
Sending        WebCore/platform/KURL.cpp
Transmitting file data ..
Committed revision 44348.