Bug 261171 - Split webkitpy.common.net.bugzilla.TestExpectationUpdater
Summary: Split webkitpy.common.net.bugzilla.TestExpectationUpdater
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-05 13:05 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-09-06 13:31 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2023-09-05 13:05:00 PDT
We should consider "getting results" and "updating based on LayoutTestResults" as separate operations in the code.

It's hard to tell how entangled this code is right now at quick glance, and hard to add support for "getting LayoutTestResults from elsewhere".
Comment 1 Sam Sneddon [:gsnedders] 2023-09-05 13:25:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17454
Comment 2 EWS 2023-09-06 13:30:11 PDT
Committed 267690@main (5b3cad0ec99c): <https://commits.webkit.org/267690@main>

Reviewed commits have been landed. Closing PR #17454 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-06 13:31:19 PDT
<rdar://problem/115073525>