RESOLVED FIXED 261148
[GStreamer][WebRTC] Some tests hitting hashtable asserts 
https://bugs.webkit.org/show_bug.cgi?id=261148
Summary [GStreamer][WebRTC] Some tests hitting hashtable asserts
Philippe Normand
Reported 2023-09-05 05:31:40 PDT
ASSERTION FAILED: m_table Thread 1 (Thread 0x7fe0d4ff96c0 (LWP 2024267)): #0 0x00007fe28bf5012e in WTFCrash() () at /var/home/phil/WebKit/Source/WTF/wtf/Assertions.cpp:327 #1 0x00007fe2934ff38b in WTFCrashWithInfo(int, char const*, char const*, int) () at WTF/Headers/wtf/Assertions.h:768 #2 0x00007fe298e69cd9 in WTF::HashTableConstIterator<WTF::HashTable<_GstElement*, WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<_GstEle ment*, std::pair<unsigned long, unsigned long> > >, WTF::DefaultHash<_GstElement*>, WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned long>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*> , WTF::HashTraits<std::pair<unsigned long, unsigned long> >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<_GstElement*> >, _GstElement*, WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsig ned long> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> > >, WTF::DefaultHash<_GstElement*>, WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned long>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*>, WTF::HashTraits<std::pair<unsigned long, unsigned long> >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<_GstElement*> >::checkVal idity() const (this=0x7fe0d4ff7d98) at WTF/Headers/wtf/HashTable.h:223 #3 0x00007fe298e6e519 in WTF::HashTableConstIterator<WTF::HashTable<_GstElement*, WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<_GstEle ment*, std::pair<unsigned long, unsigned long> > >, WTF::DefaultHash<_GstElement*>, WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned long>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*> , WTF::HashTraits<std::pair<unsigned long, unsigned long> >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<_GstElement*> >, _GstElement*, WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsig ned long> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> > >, WTF::DefaultHash<_GstElement*>, WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned long>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*>, WTF::HashTraits<std::pair<unsigned long, unsigned long> >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<_GstElement*> >::operator ++() (this=0x7fe0d4ff7d98) at WTF/Headers/wtf/HashTable.h:199 #4 0x00007fe298e6e1a5 in WTF::HashTable<_GstElement*, WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<_GstElement*, std::pair<unsigned lo ng, unsigned long> > >, WTF::DefaultHash<_GstElement*>, WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned long>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*>, WTF::HashTraits<std::pair< unsigned long, unsigned long> >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<_GstElement*> >::HashTable(WTF::HashTable<_GstElement*, WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> > >, WTF::DefaultHash<_GstElement*>, WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned lon g>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*>, WTF::HashTraits<std::pair<unsigned long, unsigned long> >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<_GstElement*> > const&) (thi s=0x7fe0d4ff7df8, other=...) at WTF/Headers/wtf/HashTable.h:1340 #5 0x00007fe298e6e065 in WTF::HashTable<_GstElement*, WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<_GstElement*, std::pair<unsigned lo ng, unsigned long> > >, WTF::DefaultHash<_GstElement*>, WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned long>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*>, WTF::HashTraits<std::pair< unsigned long, unsigned long> >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<_GstElement*> >::operator=(WTF::HashTable<_GstElement*, WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<_GstElement*, std::pair<unsigned long, unsigned long> > >, WTF::DefaultHash<_GstElement*>, WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned lon g>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*>, WTF::HashTraits<std::pair<unsigned long, unsigned long> >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<_GstElement*> > const&) (thi s=0x7fe2764755a8, other=...) at WTF/Headers/wtf/HashTable.h:1360 #6 0x00007fe298e6e031 in WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned long>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*>, WTF::HashTraits<std::pair<unsigned long, unsigned long> >, WTF::HashTableTraits>::operator=(WTF::HashMap<_GstElement*, std::pair<unsigned long, unsigned long>, WTF::DefaultHash<_GstElement*>, WTF::HashTraits<_GstElement*>, WTF::HashTraits<std::pair<unsigned long, unsig ned long> >, WTF::HashTableTraits> const&) (this=0x7fe2764755a8) at WTF/Headers/wtf/HashMap.h:35 #7 0x00007fe298e5f34e in videoFrameMetadataGetInfo()::$_0::operator()() const::{lambda(_GstBuffer*, _GstMeta*, _GstBuffer*, unsigned int, void*)#1}::operator()(_GstBuffer*, _GstMeta*, _GstBuffer*, unsigned int, v oid*) const (this=0x7fe0d4ff7ed0, buffer=0x7fe0b800c030 [None], meta=0x27f7f50, type=1319) at /var/home/phil/WebKit/Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp:96 #8 0x00007fe298e5f298 in videoFrameMetadataGetInfo()::$_0::operator()() const::{lambda(_GstBuffer*, _GstMeta*, _GstBuffer*, unsigned int, void*)#1}::__invoke(_GstBuffer*, _GstMeta*, _GstBuffer*, unsigned int, voi d*) (buffer=0x7fe0b800c030 [None], meta=0x27f7f50, type=1319) at /var/home/phil/WebKit/Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp:89 #9 0x00007fe285213dc1 in foreach_metadata (inbuf=inbuf@entry=0x27e4a60 [None], meta=meta@entry=0x7fe0d4ff7fb0, user_data=user_data@entry=0x7fe0d4ff8010) at ../libs/gst/base/gstbasetransform.c:1789 #10 0x00007fe2850cf08d in gst_buffer_foreach_meta (buffer=buffer@entry=0x27e4a60 [None], func=func@entry=0x7fe285213ca0 <foreach_metadata>, user_data=user_data@entry=0x7fe0d4ff8010) at ../gst/gstbuffer.c:2514 #11 0x00007fe285215013 in default_copy_metadata (trans=0x25bd1d0, inbuf=0x27e4a60 [None], outbuf=0x7fe0b800c030 [None]) at ../libs/gst/base/gstbasetransform.c:1826 #12 0x00007fe285214989 in default_prepare_output_buffer (trans=0x25bd1d0, inbuf=0x27e4a60 [None], outbuf=0x7fe0d4ff8160) at ../libs/gst/base/gstbasetransform.c:1718 #13 0x00007fe28520e2cf in default_generate_output (trans=0x25bd1d0, outbuf=0x7fe0d4ff8160) at ../libs/gst/base/gstbasetransform.c:2173 #14 0x00007fe28520d9f6 in gst_base_transform_chain (pad=pad@entry=0x25bd610, parent=parent@entry=0x25bd1d0, buffer=buffer@entry=0x27e4a60 [None]) at ../libs/gst/base/gstbasetransform.c:2355 #15 0x00007fe285113e5c in gst_pad_chain_data_unchecked (pad=pad@entry=0x25bd610, type=type@entry=4112, data=data@entry=0x27e4a60) at ../gst/gstpad.c:4463 #16 0x00007fe2851171fe in gst_pad_push_data (pad=pad@entry=0x25b0550, type=type@entry=4112, data=data@entry=0x27e4a60) at ../gst/gstpad.c:4739 #17 0x00007fe285117834 in gst_pad_push (pad=0x25b0550, buffer=buffer@entry=0x27e4a60 [None]) at ../gst/gstpad.c:4858 #18 0x00007fe208453562 in gst_selector_pad_chain (pad=pad@entry=0x280f7c0, parent=parent@entry=0x25b0390, buf=buf@entry=0x27e4a60 [None]) at ../plugins/elements/gstinputselector.c:1222 #19 0x00007fe285113e5c in gst_pad_chain_data_unchecked (pad=pad@entry=0x280f7c0, type=type@entry=4112, data=data@entry=0x27e4a60) at ../gst/gstpad.c:4463 #20 0x00007fe2851171fe in gst_pad_push_data (pad=pad@entry=0x25b83c0, type=type@entry=4112, data=data@entry=0x27e4a60) at ../gst/gstpad.c:4739 #21 0x00007fe285117834 in gst_pad_push (pad=0x25b83c0, buffer=0x27e4a60 [None]) at ../gst/gstpad.c:4858 #22 0x00007fe2850f8c0b in gst_proxy_pad_chain_default (pad=<optimized out>, parent=<optimized out>, buffer=0x27e4a60 [None]) at ../gst/gstghostpad.c:127 #23 0x00007fe298f7416e in webkitMediaStreamSrcChain(_GstPad*, _GstObject*, _GstBuffer*) (pad=0x25b87a0, parent=0x25b83c0, buffer=0x27e4a60 [None]) at /var/home/phil/WebKit/Source/WebCore/platform/mediastream/gstre amer/GStreamerMediaStreamSource.cpp:871 ... webrtc/video-rotation-no-cvo.html [ Crash ] webrtc/video-rotation.html [ Crash ] webrtc/video-unmute.html [ Crash ]
Attachments
Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2023-09-05 07:47:18 PDT
*** This bug has been marked as a duplicate of bug 261145 ***
Philippe Normand
Comment 2 2023-09-05 08:06:40 PDT
.
Philippe Normand
Comment 3 2023-09-05 08:20:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17441
EWS
Comment 4 2023-09-07 02:04:51 PDT
Committed 267721@main (0580cc9765f2): <https://commits.webkit.org/267721@main> Reviewed commits have been landed. Closing PR #17441 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2023-09-07 02:05:16 PDT
<rdar://problem/115103309>
Note You need to log in before you can comment on or make changes to this bug.