RESOLVED FIXED261127
Let the compiler generate more comparison operators in JSC 
https://bugs.webkit.org/show_bug.cgi?id=261127
Summary Let the compiler generate more comparison operators in JSC
Chris Dumez
Reported 2023-09-04 16:56:52 PDT
Let the compiler generate more comparison operators in JSC now that we support C++20.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2023-09-04 16:58:32 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17417
EWS
Comment 2 2023-09-05 12:41:17 PDT
Committed 267645@main (e9e93692891c): <https://commits.webkit.org/267645@main> Reviewed commits have been landed. Closing PR #17417 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-09-05 12:42:15 PDT
<rdar://problem/115001681>
Chris Dumez
Comment 4 2023-11-16 09:38:15 PST
This caused a 3MB binary size increase and I am unclear why. The compiler should in theory generate identical code to the one we had.. At first I thought it was because I newly inlined 2 of the comparison operators. However, moving them back out of line didn't reduce binary size significantly.
Darin Adler
Comment 5 2023-11-16 13:13:21 PST
Maybe the generated ones are always implicitly generated inline?
Note You need to log in before you can comment on or make changes to this bug.