WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
261096
Change --logJIT to dump its header line on a single line.
https://bugs.webkit.org/show_bug.cgi?id=261096
Summary
Change --logJIT to dump its header line on a single line.
Mark Lam
Reported
2023-09-03 21:20:26 PDT
It currently dumps one "Generated JIT code for ..." line and a second line indicating the bounds of the JIT code. This patch makes the 2 into 1 line, and adds JITCode size in bytes to the dump. This makes the dump easier to filter out / grep for info about certain JIT code generation. Other miscellaneous changes: 1. Removed unused --dumpCompilerConstructionSite option. 2. Changed JITPlan::compileInThread to cache the result of computeCompileTimes(), and to return early if it is false. The rest of the function after the call to compileInThreadImpl() are all to do dumps. Those dumps are gated on conditions which will cause computeCompileTimes() to return true if the dump is needed. Hence, there's no need to do extra work if computeCompileTimes() is false.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-09-03 21:20:43 PDT
<
rdar://problem/114916585
>
Mark Lam
Comment 2
2023-09-03 21:24:10 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/17397
EWS
Comment 3
2023-09-05 11:15:43 PDT
Committed
267639@main
(aaec31beee6c): <
https://commits.webkit.org/267639@main
> Reviewed commits have been landed. Closing PR #17397 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug