WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
261066
Handle NaN in the Audio delay curves
https://bugs.webkit.org/show_bug.cgi?id=261066
Summary
Handle NaN in the Audio delay curves
Ahmad Saleem
Reported
2023-09-02 10:37:26 PDT
Hi Team, Based on Slack's discussion with Chris 1:1, it is potential merge from Blink: Blink Commit:
https://chromium.googlesource.com/chromium/src.git/+/f6e3d4665d9261e4fef2b5931e4c75ecb5e032bf
WebKit Source:
https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp#124
______ It is fixed by following: double delayTime = m_delayTimes[i]; if (std::isnan(delayTime)) delayTime = maxDelayTime(); else delayTime = std::clamp<double>(m_delayTimes[i], 0.0, maxDelayTime()); ____ Raising this bug so we can fix it in WebKit as well. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2023-09-02 15:53:31 PDT
Committed
267589@main
(138a64742ac6): <
https://commits.webkit.org/267589@main
> Reviewed commits have been landed. Closing PR #17377 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2023-09-02 15:54:13 PDT
<
rdar://problem/114881060
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug