Bug 26106 – [GTK] Crashes when you keep a combo open during a page transition, then close it

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gustavo Noronha (kov)]

To reproduce go to any page which has a combo box. Click any link, and before the next page load is committed, click the combo box. After the new page load is committed click an option, or otherwise make the popup go away: crash.

This seems to be GTK+-specific, but I'm not yet sure. I'll try to reproduce in other ports. I'm still doing a debug build to get a proper backtrace, but this is what I got from a release build:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb52a5760 (LWP 23667)]
0xb7cefc1c in WebCore::PopupMenu::menuUnmapped ()
   from /home/kov/src/WebKit/WebKitBuild/Release/.libs/libwebkit-1.0.so.2
Current language:  auto; currently asm

[Gustavo Noronha (kov)]

Created attachment 30831 [details]
backtrace

[Gustavo Noronha (kov)]

Created attachment 30832 [details]
Make WebKitNetworkRequest a proper GObject

 ChangeLog                                  |    8 ++
 GNUmakefile.am                             |    6 +
 WebKit/gtk/ChangeLog                       |   24 ++++
 WebKit/gtk/tests/testnetworkrequest.c      |  131 +++++++++++++++++++++
 WebKit/gtk/webkit/webkitnetworkrequest.cpp |  176 +++++++++++++++++++++++-----
 WebKit/gtk/webkit/webkitnetworkrequest.h   |    4 +
 6 files changed, 320 insertions(+), 29 deletions(-)

[Gustavo Noronha (kov)]

Created attachment 30833 [details]
Avoid crashing when popup is open during page transition

 WebCore/ChangeLog                     |   15 +++++++++++++++
 WebCore/platform/gtk/PopupMenuGtk.cpp |   10 ++++++++--
 2 files changed, 23 insertions(+), 2 deletions(-)

[Gustavo Noronha (kov)]

Created attachment 30933 [details]
Avoid crashing when popup is open during page transition

 WebCore/ChangeLog                     |   15 +++++++++++++++
 WebCore/platform/gtk/PopupMenuGtk.cpp |    5 ++++-
 2 files changed, 19 insertions(+), 1 deletions(-)

[Gustavo Noronha (kov)]

Comment on attachment 30933 [details]
Avoid crashing when popup is open during page transition

Alternative solution to the client null checkproposed by zecke on IRC. Disregard the fact that the changelog still mentions nullity check, it is already fixed in my local copy, which I will commit if I get r+ =P

[Holger Freyther]

Comment on attachment 30933 [details]
Avoid crashing when popup is open during page transition

Makes sense.

[Gustavo Noronha (kov)]

Landed as r44490.