Bug 26100 - Add missing event handler properties to the DOMWindow
Summary: Add missing event handler properties to the DOMWindow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-30 18:29 PDT by Sam Weinig
Modified: 2009-06-02 10:35 PDT (History)
0 users

See Also:


Attachments
Add onstorage (6.20 KB, patch)
2009-05-31 16:56 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Add quite a few more (20.33 KB, patch)
2009-05-31 19:50 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
3 more and and a fix (7.63 KB, patch)
2009-06-01 22:58 PDT, Sam Weinig
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2009-05-30 18:29:19 PDT
The list of missing properties as of the current HTML5 standard are:

// Storage
//attribute EventListener onstorage;

// Printing
//attribute EventListener onafterprint;
//attribute EventListener onbeforeprint;

// Media
//attribute EventListener oncanplay;
//attribute EventListener oncanplaythrough;
//attribute EventListener ondurationchange;
//attribute EventListener onemptied;
//attribute EventListener onended;
//attribute EventListener onloadeddata;
//attribute EventListener onloadedmetadata;
//attribute EventListener onpause;
//attribute EventListener onplay;
//attribute EventListener onplaying;
//attribute EventListener onratechange;
//attribute EventListener onseeked;
//attribute EventListener onseeking;
//attribute EventListener ontimeupdate;
//attribute EventListener onvolumechange;
//attribute EventListener onwaiting;

// Progress
//attribute EventListener onloadstart;
//attribute EventListener onprogress;
//attribute EventListener onstalled;
//attribute EventListener onsuspend;

// Messaging
//attribute EventListener onmessage;

// Online state
//attribute EventListener onoffline;
//attribute EventListener ononline;

// Drag
//attribute EventListener ondrag;
//attribute EventListener ondragend;
//attribute EventListener ondragenter;
//attribute EventListener ondragleave;
//attribute EventListener ondragover;
//attribute EventListener ondragstart;
//attribute EventListener ondrop;

// Forms
//attribute EventListener onformchange;
//attribute EventListener onforminput;
//attribute EventListener oninput;
//attribute EventListener oninvalid;

// Undo/Redo
//attribute EventListener onredo;
//attribute EventListener onundo;

// History
//attribute EventListener onpopstate;

// Location
//attribute EventListener onhashchange;

// Context Menu
//attribute EventListener oncontextmenu;
//attribute EventListener onshow;

// Readystate
//attribute EventListener onreadystatechange;

// ???
//attribute EventListener ondataunavailable;
Comment 1 Sam Weinig 2009-05-31 15:25:34 PDT
ononline and onoffline added in r44298.
Comment 2 Sam Weinig 2009-05-31 16:56:23 PDT
Created attachment 30821 [details]
Add onstorage

Add window.onstorage.
Comment 3 Anders Carlsson 2009-05-31 17:13:41 PDT
Comment on attachment 30821 [details]
Add onstorage

r=me
Comment 4 Sam Weinig 2009-05-31 17:21:07 PDT
Onstorage patch landed in r44301.
Comment 5 Sam Weinig 2009-05-31 19:50:57 PDT
Created attachment 30823 [details]
Add quite a few more

Adds oncanplay, oncanplaythrough, ondurationchange, onemptied, onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying, onratechange, onseeked, onseeking, ontimeupdate, onvolumechange, onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag, ondragend, ondragenter, ondragleave, ondragover, ondragstart and ondrop.
Comment 6 Sam Weinig 2009-05-31 19:56:36 PDT
Second set landed in r44302.
Comment 7 Sam Weinig 2009-05-31 19:58:58 PDT
The remaining ones are now.

// Printing
//attribute EventListener onafterprint;
//attribute EventListener onbeforeprint;

// Messaging
//attribute EventListener onmessage;

// Forms
//attribute EventListener onformchange;
//attribute EventListener onforminput;
//attribute EventListener oninput;
//attribute EventListener oninvalid;

// Undo/Redo
//attribute EventListener onredo;
//attribute EventListener onundo;

// History
//attribute EventListener onpopstate;

// Location
//attribute EventListener onhashchange;

// Context Menu
//attribute EventListener oncontextmenu;
//attribute EventListener onshow;

// Readystate
//attribute EventListener onreadystatechange;

// ???
//attribute EventListener ondataunavailable;


Of that set, I believe we only support onmessage, oninput and oncontextmenu.
Comment 8 Sam Weinig 2009-06-01 22:58:00 PDT
Created attachment 30857 [details]
3 more and and a fix
Comment 9 Sam Weinig 2009-06-02 10:34:31 PDT
Landed in r44360.
Comment 10 Sam Weinig 2009-06-02 10:35:52 PDT
I will file a follow up bug about the remaining properties which we don't yet implement.