Bug 26100 – Add missing event handler properties to the DOMWindow

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Sam Weinig]

The list of missing properties as of the current HTML5 standard are:

// Storage
//attribute EventListener onstorage;

// Printing
//attribute EventListener onafterprint;
//attribute EventListener onbeforeprint;

// Media
//attribute EventListener oncanplay;
//attribute EventListener oncanplaythrough;
//attribute EventListener ondurationchange;
//attribute EventListener onemptied;
//attribute EventListener onended;
//attribute EventListener onloadeddata;
//attribute EventListener onloadedmetadata;
//attribute EventListener onpause;
//attribute EventListener onplay;
//attribute EventListener onplaying;
//attribute EventListener onratechange;
//attribute EventListener onseeked;
//attribute EventListener onseeking;
//attribute EventListener ontimeupdate;
//attribute EventListener onvolumechange;
//attribute EventListener onwaiting;

// Progress
//attribute EventListener onloadstart;
//attribute EventListener onprogress;
//attribute EventListener onstalled;
//attribute EventListener onsuspend;

// Messaging
//attribute EventListener onmessage;

// Online state
//attribute EventListener onoffline;
//attribute EventListener ononline;

// Drag
//attribute EventListener ondrag;
//attribute EventListener ondragend;
//attribute EventListener ondragenter;
//attribute EventListener ondragleave;
//attribute EventListener ondragover;
//attribute EventListener ondragstart;
//attribute EventListener ondrop;

// Forms
//attribute EventListener onformchange;
//attribute EventListener onforminput;
//attribute EventListener oninput;
//attribute EventListener oninvalid;

// Undo/Redo
//attribute EventListener onredo;
//attribute EventListener onundo;

// History
//attribute EventListener onpopstate;

// Location
//attribute EventListener onhashchange;

// Context Menu
//attribute EventListener oncontextmenu;
//attribute EventListener onshow;

// Readystate
//attribute EventListener onreadystatechange;

// ???
//attribute EventListener ondataunavailable;

[Sam Weinig]

ononline and onoffline added in r44298.

[Sam Weinig]

Created attachment 30821 [details]
Add onstorage

Add window.onstorage.

[Anders Carlsson]

Comment on attachment 30821 [details]
Add onstorage

r=me

[Sam Weinig]

Onstorage patch landed in r44301.

[Sam Weinig]

Created attachment 30823 [details]
Add quite a few more

Adds oncanplay, oncanplaythrough, ondurationchange, onemptied, onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying, onratechange, onseeked, onseeking, ontimeupdate, onvolumechange, onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag, ondragend, ondragenter, ondragleave, ondragover, ondragstart and ondrop.

[Sam Weinig]

Second set landed in r44302.

[Sam Weinig]

The remaining ones are now.

// Printing
//attribute EventListener onafterprint;
//attribute EventListener onbeforeprint;

// Messaging
//attribute EventListener onmessage;

// Forms
//attribute EventListener onformchange;
//attribute EventListener onforminput;
//attribute EventListener oninput;
//attribute EventListener oninvalid;

// Undo/Redo
//attribute EventListener onredo;
//attribute EventListener onundo;

// History
//attribute EventListener onpopstate;

// Location
//attribute EventListener onhashchange;

// Context Menu
//attribute EventListener oncontextmenu;
//attribute EventListener onshow;

// Readystate
//attribute EventListener onreadystatechange;

// ???
//attribute EventListener ondataunavailable;


Of that set, I believe we only support onmessage, oninput and oncontextmenu.

[Sam Weinig]

Created attachment 30857 [details]
3 more and and a fix

[Sam Weinig]

Landed in r44360.

[Sam Weinig]

I will file a follow up bug about the remaining properties which we don't yet implement.