RESOLVED FIXED 260997
AutoInstall.install_everything is unsafe 
https://bugs.webkit.org/show_bug.cgi?id=260997
Summary AutoInstall.install_everything is unsafe
Sam Sneddon [:gsnedders]
Reported 2023-08-31 15:01:38 PDT
INTERNALERROR> File "/Volumes/gsnedders/projects/Safari/OpenSource/Tools/Scripts/libraries/resultsdbpy/.tox/py39/lib/python3.9/site-packages/webkitcorepy/autoinstall.py", line 642, in install_everything INTERNALERROR> for packages in cls.packages.values(): INTERNALERROR> RuntimeError: dictionary changed size during iteration I believe this is caused by: AutoInstall.register(Package('twisted', Version(21, 2, 0), pypi_name='Twisted', implicit_deps=[ Package('incremental', Version(21, 3, 0)), ])) …where the AutoInstaller will AutoInstall twisted, and then recurse into its implicit_deps, and it will then register incremental as it begins to install it—thus mutating the dict being iterated over.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2023-08-31 18:01:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17317
EWS
Comment 2 2023-09-01 08:37:56 PDT
Committed 267552@main (d94691e07a31): <https://commits.webkit.org/267552@main> Reviewed commits have been landed. Closing PR #17317 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-09-01 08:38:16 PDT
<rdar://problem/114822346>
Note You need to log in before you can comment on or make changes to this bug.