Bug 26095 - Crash with 3d transform on generated content div (with ACCELERATED_COMPOSITING)
Summary: Crash with 3d transform on generated content div (with ACCELERATED_COMPOSITING)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-29 20:15 PDT by Simon Fraser (smfr)
Modified: 2009-06-12 17:11 PDT (History)
0 users

See Also:


Attachments
Patch, testcase, changelog (6.86 KB, patch)
2009-06-12 17:07 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-05-29 20:15:03 PDT
When ACCELERATED_COMPOSITING  is on, putting a 3d transform on a generated content div crashes in a debug build.
Comment 1 Simon Fraser (smfr) 2009-06-12 17:07:41 PDT
Created attachment 31222 [details]
Patch, testcase, changelog

No pixel results for the test because DRT is broken with compositing currently.
Comment 2 mitz 2009-06-12 17:09:48 PDT
Comment on attachment 31222 [details]
Patch, testcase, changelog

> +    } else {
> +        m_graphicsLayer->setName("Anonymous Node");
>      }

Please remove the braces around this 1-line block.

r=me
Comment 3 Simon Fraser (smfr) 2009-06-12 17:11:49 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/compositing/generated-content.html
	A	LayoutTests/platform/mac/compositing/generated-content-expected.txt
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderLayerBacking.cpp
Committed r44640