RESOLVED FIXED 260756
AX: Implement test_driver_internal.{get_computed_role, get_computed_label} 
https://bugs.webkit.org/show_bug.cgi?id=260756
Summary AX: Implement test_driver_internal.{get_computed_role, get_computed_label}
Tyler Wilcock
Reported 2023-08-25 19:01:27 PDT
This is necessary to run accessibility WPTs via the WebKitTestRunner.
Attachments
Patch (239.26 KB, patch)
2023-08-25 19:06 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (253.13 KB, patch)
2023-08-25 23:03 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (254.05 KB, patch)
2023-08-26 10:35 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (257.25 KB, patch)
2023-08-26 16:17 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (257.26 KB, patch)
2023-08-28 10:10 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (257.26 KB, patch)
2023-08-28 10:27 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-08-25 19:01:38 PDT
<rdar://problem/114480911>
Tyler Wilcock
Comment 2 2023-08-25 19:06:25 PDT
Created attachment 467448 [details] Patch
Tyler Wilcock
Comment 3 2023-08-25 23:03:23 PDT
Created attachment 467450 [details] Patch
Tyler Wilcock
Comment 4 2023-08-26 10:35:30 PDT
Created attachment 467451 [details] Patch
Tyler Wilcock
Comment 5 2023-08-26 16:17:48 PDT
Created attachment 467453 [details] Patch
chris fleizach
Comment 6 2023-08-27 23:16:20 PDT
Comment on attachment 467453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467453&action=review > Source/WebCore/testing/Internals.cpp:7161 > +AccessibilityObject* Internals::axObjectFor(Element& element) const is this style of naming used in WebKit? I would have expected the name to be axObjectForElement > Source/WebCore/testing/Internals.cpp:7198 > + return element.renderer() || !element.rendererIsNeeded(*computedStyle); we've already checked element.renderer() above. do we need to check it here too?
Tyler Wilcock
Comment 7 2023-08-28 10:10:14 PDT
Created attachment 467459 [details] Patch
Tyler Wilcock
Comment 8 2023-08-28 10:27:54 PDT
Created attachment 467460 [details] Patch
EWS
Comment 9 2023-08-28 14:49:21 PDT
Committed 267364@main (33b030f32890): <https://commits.webkit.org/267364@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467460 [details].
Note You need to log in before you can comment on or make changes to this bug.