RESOLVED FIXED 260750
Placate exception check validation in sanitizeRemoteFunctionException.
https://bugs.webkit.org/show_bug.cgi?id=260750
Summary Placate exception check validation in sanitizeRemoteFunctionException.
Mark Lam
Reported 2023-08-25 17:11:54 PDT
sanitizeRemoteFunctionException() can call JSValue::toWTFString() which may throw under certain circumstances. However, it is only called here if exceptionValue.isPrimitive() i.e. it will never throw. However, the exception check validator does not know this. So, we added a `ASSERT(!scope.exception())` to placate it. However, if we're forcing exception check validation on a Release build, the ASSERT turns into a no-op. The fix is to use EXCEPTION_ASSERT here instead.
Attachments
Radar WebKit Bug Importer
Comment 1 2023-08-25 17:12:15 PDT
Mark Lam
Comment 2 2023-08-25 17:15:33 PDT
EWS
Comment 3 2023-08-25 18:13:21 PDT
Committed 267311@main (9b124cc4e156): <https://commits.webkit.org/267311@main> Reviewed commits have been landed. Closing PR #17093 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.