RESOLVED FIXED 26075
[GTK] Refactor key scrolling code 
https://bugs.webkit.org/show_bug.cgi?id=26075
Summary [GTK] Refactor key scrolling code
Xan Lopez
Reported 2009-05-29 02:36:46 PDT
Patch attached with explanation.
Attachments
scroll.patch (4.06 KB, patch)
2009-05-29 02:38 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
scrollv2.patch (3.81 KB, patch)
2009-05-29 04:38 PDT, Xan Lopez 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2009-05-29 02:38:04 PDT
Created attachment 30770 [details] scroll.patch
Xan Lopez
Comment 2 2009-05-29 04:34:04 PDT
This seems to break scrolling in the Acid2 test :/ I thought we were always guaranteed to have a scrollbar, even if it would be a dummy one, but apparently in that case WebCore thinks we don't have one and scrolling fails when using ScrollView::scroll. Guess I'm missing something here?
Xan Lopez
Comment 3 2009-05-29 04:38:34 PDT
Created attachment 30774 [details] scrollv2.patch Be more consistent with our previous implementation, always return true and do not scroll parent views (not sure if that's correct or not). My previous comment still applies though.
Gustavo Noronha (kov)
Comment 4 2009-05-29 08:50:57 PDT
Comment on attachment 30774 [details] scrollv2.patch Looks good to me. Testing in Chromium/Linux and asking people to test on Safari indicates that not scrolling in acid2 is actually the right thing, so this fixes a bug =).
Xan Lopez
Comment 5 2009-05-29 08:57:01 PDT
Landed as r44264, thanks!
Note You need to log in before you can comment on or make changes to this bug.