Bug 260745 - RETURN_IF_EXCEPTION should work for Release builds too.
Summary: RETURN_IF_EXCEPTION should work for Release builds too.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-25 16:12 PDT by Mark Lam
Modified: 2023-08-25 16:21 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-08-25 16:12:29 PDT 
In PlatformEnable.h, we can force ENABLE_EXCEPTION_SCOPE_VERIFICATION to be on so that we can get validate exception checks with a Release build.  However, RETURN_IF_EXCEPTION is relying on an ASSERT to tickle the exception check validator.  The right thing to do is to use EXCEPTION_ASSERT instead.
Comment 1 Radar WebKit Bug Importer 2023-08-25 16:12:48 PDT 
<rdar://problem/114475322>
Comment 2 Mark Lam 2023-08-25 16:17:02 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17090
Comment 3 EWS 2023-08-25 16:21:05 PDT 
Committed 267303@main (c0b02e6b685b): <https://commits.webkit.org/267303@main>

Reviewed commits have been landed. Closing PR #17090 and removing active labels.