WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
260745
RETURN_IF_EXCEPTION should work for Release builds too.
https://bugs.webkit.org/show_bug.cgi?id=260745
Summary
RETURN_IF_EXCEPTION should work for Release builds too.
Mark Lam
Reported
2023-08-25 16:12:29 PDT
In PlatformEnable.h, we can force ENABLE_EXCEPTION_SCOPE_VERIFICATION to be on so that we can get validate exception checks with a Release build. However, RETURN_IF_EXCEPTION is relying on an ASSERT to tickle the exception check validator. The right thing to do is to use EXCEPTION_ASSERT instead.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-08-25 16:12:48 PDT
<
rdar://problem/114475322
>
Mark Lam
Comment 2
2023-08-25 16:17:02 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/17090
EWS
Comment 3
2023-08-25 16:21:05 PDT
Committed
267303@main
(c0b02e6b685b): <
https://commits.webkit.org/267303@main
> Reviewed commits have been landed. Closing PR #17090 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug