Bug 26074 - SQLTransaction::executeSQL does an unnecessary call to String::copy.
Summary: SQLTransaction::executeSQL does an unnecessary call to String::copy.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-29 01:09 PDT by David Levin
Modified: 2009-05-29 14:38 PDT (History)
1 user (show)

See Also:


Attachments
Proposed fix. (1.34 KB, patch)
2009-05-29 01:13 PDT, David Levin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-05-29 01:09:27 PDT
The 1st argument is a string that is copied in this call:
 
   ... SQLStatement::create(sqlStatement.copy(), ...);


SQLStatement also copies this string (see WebCore/storage/SQLStatement.cpp):

  SQLStatement::SQLStatement(const String& statement, ...)
      : m_statement(statement.copy())
Comment 1 David Levin 2009-05-29 01:13:11 PDT
Created attachment 30767 [details]
Proposed fix.
Comment 2 Brent Fulgham 2009-05-29 14:38:39 PDT
Landed in @r44274.