WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26074
SQLTransaction::executeSQL does an unnecessary call to String::copy.
https://bugs.webkit.org/show_bug.cgi?id=26074
Summary
SQLTransaction::executeSQL does an unnecessary call to String::copy.
David Levin
Reported
2009-05-29 01:09:27 PDT
The 1st argument is a string that is copied in this call: ... SQLStatement::create(sqlStatement.copy(), ...); SQLStatement also copies this string (see WebCore/storage/SQLStatement.cpp): SQLStatement::SQLStatement(const String& statement, ...) : m_statement(statement.copy())
Attachments
Proposed fix.
(1.34 KB, patch)
2009-05-29 01:13 PDT
,
David Levin
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2009-05-29 01:13:11 PDT
Created
attachment 30767
[details]
Proposed fix.
Brent Fulgham
Comment 2
2009-05-29 14:38:39 PDT
Landed in @
r44274
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug