NEW 260721
Refactor compare-results to have more consistent style 
https://bugs.webkit.org/show_bug.cgi?id=260721
Summary Refactor compare-results to have more consistent style
james
Reported 2023-08-25 11:00:16 PDT
Refactor the compare-results script to make it simpler to add in new versions of previous benchmarks. 1. Have the script align with the PEP 8 style guideline by at least changing function names, variable names, and resolve inconsistent spacing issues. 2. Remove unreachable code and reduce redundant/repeated code This is a follow up to https://github.com/WebKit/WebKit/pull/16794#discussion_r1302207710
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-09-01 11:01:14 PDT
<rdar://problem/114829494>
hysu
Comment 2 2023-09-01 13:41:20 PDT
On further thought, it's probably not the best idea to do style cleanup for the sake of style cleanup in this case, since it'll obfuscate the change history quite a bit and may break other scripts that depend on these functions. For example, I think renaming all the functions to not be camelcase just for the sake of being good Pythonic style is probably not the thing to do here. Though, I think there is a value to combining duplicated logic and auditing it to make sure that everything we expect to run is running - but at that point, it's not really a style change patch anymore.
Note You need to log in before you can comment on or make changes to this bug.