Bug 26072 - Add WML <select> element support
Summary: Add WML <select> element support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 20393
  Show dependency treegraph
 
Reported: 2009-05-28 16:59 PDT by Nikolas Zimmermann
Modified: 2009-05-30 19:47 PDT (History)
1 user (show)

See Also:


Attachments
Initial patch (71.52 KB, patch)
2009-05-28 17:10 PDT, Nikolas Zimmermann
staikos: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2009-05-28 16:59:25 PDT
Add support for the last missing WML element: <select>. A first version of this patch will only add the WMLSelectElement skeleton and integrate it. WML specific features (variable substitution etc.) will follow afterwards.
Comment 1 Nikolas Zimmermann 2009-05-28 17:10:03 PDT
Created attachment 30759 [details]
Initial patch

Adding initial version of the patch.
Comment 2 Nikolas Zimmermann 2009-05-29 18:40:56 PDT
Landed in r44283.
Comment 3 Darin Adler 2009-05-30 13:44:53 PDT
Comment on attachment 30759 [details]
Initial patch

This patch broke tab key handling when the focus is on a <select> element.
Comment 4 George Staikos 2009-05-30 18:24:41 PDT
Appears to have been fixed now, correct?
Comment 5 Nikolas Zimmermann 2009-05-30 19:47:25 PDT
(In reply to comment #4)
> Appears to have been fixed now, correct?
Yes Darin already took care of fixing the regression. Thanks for that!