Bug 260702 - Build fix after 160450@main by guarding showRenderTree
Summary: Build fix after 160450@main by guarding showRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-25 00:12 PDT by ChangSeok Oh
Modified: 2023-08-25 01:26 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2023-08-25 00:12:42 PDT 
Adding a build flag, "-DLOG_DISABLED=0" breaks the build with the following messages.

/app/webkit/Source/WebCore/page/LocalFrameViewLayoutContext.cpp: In member function ‘void WebCore::LocalFrameViewLayoutContext::performLayout()’:
/app/webkit/Source/WebCore/page/LocalFrameViewLayoutContext.cpp:248:13: error: ‘showRenderTree’ was not declared in this scope
  248 |             showRenderTree(renderView());
      |             ^~~~~~~~~~~~~~                                                   
[1313/2437] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-767013ce-10.cpp.o
ninja: build stopped: subcommand failed.
Comment 1 EWS 2023-08-25 01:25:51 PDT 
Committed 267268@main (9e05696bcb54): <https://commits.webkit.org/267268@main>

Reviewed commits have been landed. Closing PR #17060 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-08-25 01:26:15 PDT 
<rdar://problem/114437045>