Bug 26069 - Fix a crash in custom V8 bindings code for XMLHttpRequest.
: Fix a crash in custom V8 bindings code for XMLHttpRequest.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Jian Li
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-28 14:47 PDT by Jian Li
Modified: 2009-05-29 16:18 PDT (History)
2 users (show)

See Also:


Attachments
Proposed Patch (1.71 KB, patch)
2009-05-28 14:54 PDT, Jian Li
no flags Details | Formatted Diff | Diff
Proposed Patch (4.46 KB, patch)
2009-05-29 14:12 PDT, Jian Li
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-05-28 14:47:25 PDT
Fix a crash in custom V8 bindings code for XMLHttpRequest. Please see
http://code.google.com/p/chromium/issues/detail?id=12792 for more details.
Comment 1 Jian Li 2009-05-28 14:54:40 PDT
Created attachment 30753 [details]
Proposed Patch
Comment 2 Dimitri Glazkov (Google) 2009-05-28 16:36:08 PDT
Is there a layout test that we could be used to exercise this fix?
Comment 3 Jian Li 2009-05-28 17:07:02 PDT
(In reply to comment #2)
> Is there a layout test that we could be used to exercise this fix?
> 

I am afraid no. I could add one in WebKit. How do you think?
Comment 4 Jian Li 2009-05-29 14:12:05 PDT
Created attachment 30788 [details]
Proposed Patch
Comment 5 Dimitri Glazkov (Google) 2009-05-29 14:33:54 PDT
Comment on attachment 30788 [details]
Proposed Patch

Excellent.
Comment 6 Jian Li 2009-05-29 16:18:13 PDT
Committed as http://trac.webkit.org/changeset/44275.