Bug 26067 - Chromium build broken by IntSize change
Summary: Chromium build broken by IntSize change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Normal
Assignee: Brett Wilson (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-28 13:30 PDT by Brett Wilson (Google)
Modified: 2009-05-28 14:23 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.08 KB, patch)
2009-05-28 13:46 PDT, Brett Wilson (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Wilson (Google) 2009-05-28 13:30:43 PDT
https://bugs.webkit.org/show_bug.cgi?id=8736 broke the Chromium build which has stricter warnings. The addition of scale() to IntSize implicitly casts a float to int.

Simon, are you sure this shouldn't round to nearest rather than round down?
Comment 1 Brett Wilson (Google) 2009-05-28 13:46:57 PDT
Created attachment 30748 [details]
Patch
Comment 2 Brett Wilson (Google) 2009-05-28 14:15:10 PDT
Checked in as 44252
Comment 3 Brett Wilson (Google) 2009-05-28 14:15:33 PDT
Comment on attachment 30748 [details]
Patch

Simon, it would still be nice if you could check this after the fact.
Comment 4 Simon Fraser (smfr) 2009-05-28 14:23:59 PDT
This change is fine. I followed IntRect::scale(), which uses C-style casts.