REGRESSION(266644@main): [wk2] http/tests/security/referrer-policy-header.html is a flaky text failure, crash

[Ben Schwartz]

http/tests/security/referrer-policy-header.html

This test is a flaky failure/crash on wk2 on all platforms.

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2Freferrer-policy-header.html

TEXT DIFF (for failure):

 PASS actualReferrer is "https://127.0.0.1:8443/security/resources/serve-referrer-policy-and-test.py?value=no-referrer-when-downgrade&destinationOrigin=https://127.0.0.1:8443/&isTestingMultipart=0&id=10"
 
 Testing 'Referrer-Policy: no-referrer-when-downgrade' - referrer origin: https://127.0.0.1:8443/ - destination origin: http://127.0.0.1:8000/ - isMultipartResponse? false
-PASS actualReferrer is ""
+FAIL actualReferrer should be . Was http://127.0.0.1:8000/security/resources/postReferrer.py?id=11.
 
 Testing 'Referrer-Policy: same-origin' - referrer origin: https://127.0.0.1:8443/ - destination origin: https://localhost:8443/ - isMultipartResponse? false
 PASS actualReferrer is ""
@@ -55,7 +55,7 @@
 PASS actualReferrer is "https://127.0.0.1:8443/"
 
 Testing 'Referrer-Policy: strict-origin' - referrer origin: https://127.0.0.1:8443/ - destination origin: http://127.0.0.1:8000/ - isMultipartResponse? false
-PASS actualReferrer is ""
+FAIL actualReferrer should be . Was http://127.0.0.1:8000/.
 
 Testing 'Referrer-Policy: strict-origin-when-cross-origin' - referrer origin: https://127.0.0.1:8443/ - destination origin: https://localhost:8443/ - isMultipartResponse? false
 PASS actualReferrer is "https://127.0.0.1:8443/"
@@ -85,15 +85,16 @@
 PASS actualReferrer is ""
 
 Testing 'Referrer-Policy: ' - referrer origin: https://127.0.0.1:8443/ - destination origin: https://localhost:8443/ - isMultipartResponse? false
-PASS actualReferrer is "https://127.0.0.1:8443/"
+FAIL actualReferrer should be https://127.0.0.1:8443/ (of type string). Was undefined (of type undefined).
 
 Testing 'Referrer-Policy: ' - referrer origin: https://127.0.0.1:8443/ - destination origin: https://127.0.0.1:8443/ - isMultipartResponse? false
-PASS actualReferrer is "https://127.0.0.1:8443/security/resources/serve-referrer-policy-and-test.py?value=&destinationOrigin=https://127.0.0.1:8443/&isTestingMultipart=0&id=28"
+FAIL actualReferrer should be https://127.0.0.1:8443/security/resources/serve-referrer-policy-and-test.py?value=&destinationOrigin=https://127.0.0.1:8443/&isTestingMultipart=0&id=28 (of type string). Was undefined (of type undefined).
 
 Testing 'Referrer-Policy: ' - referrer origin: https://127.0.0.1:8443/ - destination origin: http://127.0.0.1:8000/ - isMultipartResponse? false
-PASS actualReferrer is ""
+FAIL actualReferrer should be  (of type string). Was undefined (of type undefined).
 
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE

DIFF URL (for failure):

https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/266644@main%20(10460)/http/tests/security/referrer-policy-header-pretty-diff.html

CRASH LOG:

...
2023-08-09 21:24:36.295 com.apple.WebKit.WebContent.Development[9760:3981302] XType: can't switch to GlobalFontRegistry.  XTFontStaticRegistry is not enabled.
2023-08-09 21:24:38.533 com.apple.WebKit.WebContent.Development[9760:3981302] XType: can't switch to GlobalFontRegistry.  XTFontStaticRegistry is not enabled.
2023-08-09 21:24:41.169 com.apple.WebKit.WebContent.Development[9760:3981302] XType: can't switch to GlobalFontRegistry.  XTFontStaticRegistry is not enabled.
2023-08-09 21:24:43.659 com.apple.WebKit.WebContent.Development[9760:3981302] XType: can't switch to GlobalFontRegistry.  XTFontStaticRegistry is not enabled.
com.apple.WebKit.WebContent.Development terminated (pid 9760) for reason: crash
#CRASHED - com.apple.WebKit.WebContent.Development (pid 9760)

REPRODUCIBILITY:

I was able to reproduce this bug on macOS Ventura 13.5 (22G74/arm64) running the test as follows:

run-webkit-tests --clobber-old-results --verbose --iterations 100 --exit-after-n-failures 1 http/tests/security/referrer-policy-header.html

REGRESSION:

I was able to bisect a regression point using the flakiness dashboard. This test reproduced at 266644@main, but it did not reproduce at 266643@main. Changes at 266644@main appear to be directly related to this error, and is likely what caused the failure.

[Radar WebKit Bug Importer]

<rdar://problem/114349670>

[EWS]

Test gardening commit 267208@main (2c0d424af07a): <https://commits.webkit.org/267208@main>

Reviewed commits have been landed. Closing PR #16996 and removing active labels.

[Ryan Reno]

Pull request: https://github.com/WebKit/WebKit/pull/17019

[EWS]

Committed 267241@main (d4d875b3f050): <https://commits.webkit.org/267241@main>

Reviewed commits have been landed. Closing PR #17019 and removing active labels.