Bug 26048 - navigation-policy-decision-requested documentation incomplete
Summary: navigation-policy-decision-requested documentation incomplete
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-27 14:38 PDT by Adrian Bunk
Modified: 2009-05-28 11:39 PDT (History)
1 user (show)

See Also:


Attachments
Improve policy decision signals documentation (2.95 KB, patch)
2009-05-28 11:17 PDT, Gustavo Noronha (kov)
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Bunk 2009-05-27 14:38:11 PDT
I was quite surprised to hear that when returning TRUE from a navigation-policy-decision-requested handler, it is expected that webkit_policy_decision_* was called on policy_decision.

Please add this information to http://webkitgtk.org/reference/webkitgtk-WebKitWebView.html#WebKitWebView-navigation-policy-decision-requested
Comment 1 Gustavo Noronha (kov) 2009-05-28 11:17:50 PDT
Created attachment 30741 [details]
Improve policy decision signals documentation

 WebKit/gtk/ChangeLog                |   14 ++++++++++++++
 WebKit/gtk/webkit/webkitwebview.cpp |   21 +++++++++++++++++++++
 2 files changed, 35 insertions(+), 0 deletions(-)
Comment 2 Gustavo Noronha (kov) 2009-05-28 11:39:59 PDT
Landed as r44248, with a small addition I talked to Xan about on IRC.