WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
260434
Make it possible to put fuzzy pixel matching thresholds in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=260434
Summary
Make it possible to put fuzzy pixel matching thresholds in TestExpectations
Matthieu Dubet
Reported
2023-08-19 11:51:42 PDT
We should have a new kind of test expectations to precisely defined how many pixels difference we have with the reference, to avoid any regression/show improvement.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-08-19 11:51:57 PDT
<
rdar://problem/114138795
>
Alexey Proskuryakov
Comment 2
2023-08-21 08:27:09 PDT
An older proposal was to add a mask image that precisely defines which pixels can be different. It's more complicated to implement of course, especially as we'd need tooling to create such masks.
Simon Fraser (smfr)
Comment 3
2023-08-21 09:54:44 PDT
Fuzzy matching can specify a range of pixels (but not which ones).
Simon Fraser (smfr)
Comment 4
2023-08-21 09:55:22 PDT
Oh, I think the request here is to put the fuzzy matching data in TestExpectations, rather than in the test. Matthieu, could you clarify what you're asking for?
Matthieu Dubet
Comment 5
2024-03-20 11:00:32 PDT
@Simon, Yes this is about our expectations/our current state, so it should be in the TestExpectations (like the textual expectations with a bunch of PASS and FAIL) It's not about fuzzing per se (but it could reuse the fuzzing infrastructure to determine the pixel differences).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug