RESOLVED FIXED 260426
[IFC] Cache canUseSimplifiedTextMeasuring on RenderText 
https://bugs.webkit.org/show_bug.cgi?id=260426
Summary [IFC] Cache canUseSimplifiedTextMeasuring on RenderText
zalan
Reported 2023-08-19 05:29:47 PDT
ssia
Attachments
Patch (4.81 KB, patch)
2023-08-19 05:54 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (5.24 KB, patch)
2023-08-19 05:59 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2023-08-19 05:54:49 PDT
Created attachment 467341 [details] Patch
zalan
Comment 2 2023-08-19 05:59:29 PDT
Created attachment 467342 [details] [fast-cq]Patch
Radar WebKit Bug Importer
Comment 3 2023-08-19 09:01:14 PDT
<rdar://problem/114135839>
Antti Koivisto
Comment 4 2023-08-20 18:50:08 PDT
Comment on attachment 467342 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467342&action=review > Source/WebCore/rendering/RenderText.h:258 > std::optional<float> m_minWidth; > std::optional<float> m_maxWidth; > + std::optional<bool> m_canUseSimplifiedTextMeasuring { }; These waste some space.
zalan
Comment 5 2023-08-20 20:54:25 PDT
(In reply to Antti Koivisto from comment #4) > Comment on attachment 467342 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467342&action=review > > > Source/WebCore/rendering/RenderText.h:258 > > std::optional<float> m_minWidth; > > std::optional<float> m_maxWidth; > > + std::optional<bool> m_canUseSimplifiedTextMeasuring { }; > > These waste some space. Indeed. Will take care of that in a separate patch.
EWS
Comment 6 2023-08-20 20:58:04 PDT
Committed 267081@main (8f6d89b32a38): <https://commits.webkit.org/267081@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467342 [details].
Note You need to log in before you can comment on or make changes to this bug.