Bug 260426 - [IFC] Cache canUseSimplifiedTextMeasuring on RenderText
Summary: [IFC] Cache canUseSimplifiedTextMeasuring on RenderText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-19 05:29 PDT by zalan
Modified: 2023-08-20 20:58 PDT (History)
12 users (show)

See Also:

Attachments
Patch (4.81 KB, patch)
2023-08-19 05:54 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (5.24 KB, patch)
2023-08-19 05:59 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-08-19 05:29:47 PDT 
ssia
Comment 1 zalan 2023-08-19 05:54:49 PDT 
Created attachment 467341 [details]
Patch
Comment 2 zalan 2023-08-19 05:59:29 PDT 
Created attachment 467342 [details]
[fast-cq]Patch
Comment 3 Radar WebKit Bug Importer 2023-08-19 09:01:14 PDT 
<rdar://problem/114135839>
Comment 4 Antti Koivisto 2023-08-20 18:50:08 PDT 
Comment on attachment 467342 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467342&action=review

> Source/WebCore/rendering/RenderText.h:258
>      std::optional<float> m_minWidth;
>      std::optional<float> m_maxWidth;
> +    std::optional<bool> m_canUseSimplifiedTextMeasuring { };

These waste some space.
Comment 5 zalan 2023-08-20 20:54:25 PDT 
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 467342 [details]
> [fast-cq]Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467342&action=review
> 
> > Source/WebCore/rendering/RenderText.h:258
> >      std::optional<float> m_minWidth;
> >      std::optional<float> m_maxWidth;
> > +    std::optional<bool> m_canUseSimplifiedTextMeasuring { };
> 
> These waste some space.
Indeed. Will take care of that in a separate patch.
Comment 6 EWS 2023-08-20 20:58:04 PDT 
Committed 267081@main (8f6d89b32a38): <https://commits.webkit.org/267081@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467342 [details].