Bug 260365 - Make VTTCue.size() from 'int' to 'double'
Summary: Make VTTCue.size() from 'int' to 'double'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-08-17 15:16 PDT by Ahmad Saleem
Modified: 2023-08-18 09:15 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-08-17 15:16:48 PDT
Hi Team,

While going through WPT failures, I noticed that we are failing following test:

WPT Test Case: https://wpt.fyi/results/webvtt/api/VTTCue/size.html?label=experimental&label=master&aligned

WPT Live Link: http://wpt.live/webvtt/api/VTTCue/size.html

I started looking and noticed that in IDL file, we have it as double but in VTTCue.cpp and VTTCue.h, we have it as 'int', which is just whole number and on local build after changing it to 'double', it make us pass the following test.

Interface IDL Web-Spec: https://w3c.github.io/webvtt/#the-vttcue-interface

It is just to align with spec and start using 'double'.

Just raising so I can fix it.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-08-18 09:04:26 PDT
<rdar://problem/114089775>
Comment 2 EWS 2023-08-18 09:15:22 PDT
Committed 267041@main (b93351e6debe): <https://commits.webkit.org/267041@main>

Reviewed commits have been landed. Closing PR #16808 and removing active labels.