Bug 260357 – AX: Unify check for whether an Element can have AX relations.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

.

[Radar WebKit Bug Importer]

<rdar://problem/114035912>

[Andres Gonzalez]

Created attachment 467312 [details]
Patch

[Tyler Wilcock]

Comment on attachment 467312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467312&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:4387
> +    return !(element.hasTagName(metaTag) || element.hasTagName(headTag) || element.hasTagName(scriptTag) || element.hasTagName(htmlTag) || element.hasTagName(styleTag));

What do you think reads better, this, or "!element.hasTagName(metaTag) && !element.hasTagName(headTag) && !element.hasTagName()..."

I prefer the latter, but don't feel too strongly.

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 467312 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467312&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:4387
> > +    return !(element.hasTagName(metaTag) || element.hasTagName(headTag) || element.hasTagName(scriptTag) || element.hasTagName(htmlTag) || element.hasTagName(styleTag));
> 
> What do you think reads better, this, or "!element.hasTagName(metaTag) &&
> !element.hasTagName(headTag) && !element.hasTagName()..."
> 
> I prefer the latter, but don't feel too strongly.

I prefer the former but don't feel strongly :-) It is shorter and less chances to miss a !

[EWS]

Committed 267027@main (3677b9c10c62): <https://commits.webkit.org/267027@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467312 [details].