Bug 26035 - Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
Summary: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-05-26 17:57 PDT by Cameron Zwarich (cpst)
Modified: 2009-05-26 22:20 PDT (History)
0 users

See Also:


Attachments
Proposed patch (1.80 KB, patch)
2009-05-26 19:20 PDT, Cameron Zwarich (cpst)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2009-05-26 17:57:10 PDT
There is a FIXME in the code to return false for JPEG and other image formats that don't support transparency. JPEG is the most common of these, so we should simply do this optimization.
Comment 1 Cameron Zwarich (cpst) 2009-05-26 17:57:35 PDT
<rdar://problem/6924087>
Comment 2 Cameron Zwarich (cpst) 2009-05-26 19:20:04 PDT
Created attachment 30691 [details]
Proposed patch
Comment 3 Maciej Stachowiak 2009-05-26 21:37:30 PDT
Comment on attachment 30691 [details]
Proposed patch

r=me
Comment 4 Cameron Zwarich (cpst) 2009-05-26 22:20:41 PDT
Landed in r44176.