RESOLVED FIXED 260326
Add support for Error.captureStackTrace 
https://bugs.webkit.org/show_bug.cgi?id=260326
Summary Add support for Error.captureStackTrace
Keith Miller
Reported 2023-08-16 19:47:30 PDT
v8 has this API and it shows up in benchmarks. We should support it too.
Attachments
Add attachment proposed patch, testcase, etc.
Jarred Sumner
Comment 1 2023-08-16 20:14:05 PDT
oh nice We implemented this in Bun, but I don't feel great about our implementation. We based it on the node-jsc implementation from years ago and we didn't have as good of an understanding of JSC internals when it was implemented. One thing we also did somewhat related to this was add an `onComputeError` WTF::Function in JSC::VM which lets us provide a sourcemapped Error.prototype.stack property and match the V8 stack string format (so that libraries expecting it work). ErrorInstance calls this to generate the stack string
Keith Miller
Comment 2 2023-08-17 07:58:45 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16790
EWS
Comment 3 2023-08-17 13:06:05 PDT
Committed 267010@main (997e074bb35e): <https://commits.webkit.org/267010@main> Reviewed commits have been landed. Closing PR #16790 and removing active labels.
Radar WebKit Bug Importer
Comment 4 2023-08-17 13:07:16 PDT
<rdar://problem/114042574>
Mark Lam
Comment 5 2023-08-17 13:15:51 PDT
<rdar://problem/113767788>
Note You need to log in before you can comment on or make changes to this bug.