WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26018
Fix behavior of the Element View for double clicking the element outline tree
https://bugs.webkit.org/show_bug.cgi?id=26018
Summary
Fix behavior of the Element View for double clicking the element outline tree
Takeshi Yoshino
Reported
2009-05-26 03:02:24 PDT
Fix behavior of the Element View of the Web Inspector for double clicking the element outline tree. Double clicking the element outline tree should 1) on attribute: enter attribute editing mode 2) on text: enter text editing mode 3) otherwise: change root node to the parent element of double clicked element. Now, 3) is broken. For example, clicking <html> clears the element outline view. rootDOMNode should be updated to this.representedObject.parentNode, not this.parent.representedObject which is parent inside the element outline tree itself.
Attachments
Proposed fix for 26018
(1.71 KB, patch)
2009-05-26 03:04 PDT
,
Takeshi Yoshino
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Takeshi Yoshino
Comment 1
2009-05-26 03:04:39 PDT
Created
attachment 30665
[details]
Proposed fix for 26018
Darin Adler
Comment 2
2009-05-26 09:08:27 PDT
Comment on
attachment 30665
[details]
Proposed fix for 26018 r=me
Takeshi Yoshino
Comment 3
2009-05-26 21:33:50 PDT
Thank you for review. Could you please land this? I don't have commit access.
David Levin
Comment 4
2009-05-29 11:01:57 PDT
Assign to levin for landing.
David Levin
Comment 5
2009-05-29 16:06:04 PDT
Committed as
http://trac.webkit.org/changeset/44280
Takeshi Yoshino
Comment 6
2009-05-31 19:41:13 PDT
Thank you all for reviewing and landing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug