Bug 26018 - Fix behavior of the Element View for double clicking the element outline tree
Summary: Fix behavior of the Element View for double clicking the element outline tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-26 03:02 PDT by Takeshi Yoshino
Modified: 2009-05-31 19:41 PDT (History)
0 users

See Also:


Attachments
Proposed fix for 26018 (1.71 KB, patch)
2009-05-26 03:04 PDT, Takeshi Yoshino
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takeshi Yoshino 2009-05-26 03:02:24 PDT
Fix behavior of the Element View of the Web Inspector for double
clicking the element outline tree.

Double clicking the element outline tree should
1) on attribute: enter attribute editing mode
2) on text: enter text editing mode
3) otherwise: change root node to the parent element of double clicked
   element.

Now, 3) is broken. For example, clicking <html> clears the element
outline view.

rootDOMNode should be updated to this.representedObject.parentNode, not
this.parent.representedObject which is parent inside the element
outline tree itself.
Comment 1 Takeshi Yoshino 2009-05-26 03:04:39 PDT
Created attachment 30665 [details]
Proposed fix for 26018
Comment 2 Darin Adler 2009-05-26 09:08:27 PDT
Comment on attachment 30665 [details]
Proposed fix for 26018

r=me
Comment 3 Takeshi Yoshino 2009-05-26 21:33:50 PDT
Thank you for review. Could you please land this? I don't have commit access.
Comment 4 David Levin 2009-05-29 11:01:57 PDT
Assign to levin for landing.
Comment 5 David Levin 2009-05-29 16:06:04 PDT
Committed as http://trac.webkit.org/changeset/44280
Comment 6 Takeshi Yoshino 2009-05-31 19:41:13 PDT
Thank you all for reviewing and landing.