Bug 26012 - Chromium doesn't handle -webkit-border-image correctly.
: Chromium doesn't handle -webkit-border-image correctly.
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: PC Windows XP
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-05-25 12:16 PST by
Modified: 2009-05-26 09:00 PST (History)


Attachments
Fix for Chromium Image::drawPattern() issue. (2.49 KB, patch)
2009-05-25 12:20 PST, Stephen White
dglazkov: review+
Review Patch | Details | Formatted Diff | Diff
Fix ChangeLog (2.54 KB, patch)
2009-05-26 08:15 PST, Stephen White
dglazkov: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-05-25 12:16:55 PST
Chromium (skia) doesn't do -webkit-border-image correctly when the border image is 1 pixel wide or high, since it doesn't like negative width/height source rects in Image::drawPattern().  CoreGraphics will happily draw it in this case.  See bug http://crbug.com/6167.
------- Comment #1 From 2009-05-25 12:20:29 PST -------
Created an attachment (id=30658) [details]
Fix for Chromium Image::drawPattern() issue.
------- Comment #2 From 2009-05-25 14:37:22 PST -------
Putting Brett as the reviewer doesn't make much sense as Brett is not a WebKit reviewer.  We don't typically nominate a specific reviewer anyway.
------- Comment #3 From 2009-05-26 07:42:02 PST -------
(In reply to comment #2)
> Putting Brett as the reviewer doesn't make much sense as Brett is not a WebKit
> reviewer.

Whoops, will fix.

> We don't typically nominate a specific reviewer anyway.

In my experience, patches tend to get ignored if you don't.
------- Comment #4 From 2009-05-26 08:01:59 PST -------
(From update of attachment 30658 [details])
Thanks for fixing this!

Don't forget a bug URL in the ChangeLog.
------- Comment #5 From 2009-05-26 08:15:30 PST -------
Created an attachment (id=30669) [details]
Fix ChangeLog
------- Comment #6 From 2009-05-26 09:00:56 PST -------
Landed as http://trac.webkit.org/changeset/44150.