Bug 260109 - JetStream2/JetStream3 should report results in a better way
Summary: JetStream2/JetStream3 should report results in a better way
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-11 17:35 PDT by hysu
Modified: 2023-08-18 17:36 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hysu 2023-08-11 17:35:48 PDT 
The JetStream2 and JetStream3 harnesses currently report results using `fetch`. Because the header is manually constructed, and there is a typo in both harnesses ("headers" -> "heeaders").
JS2: https://github.com/WebKit/WebKit/blob/ec6f02c2f3242338888639458e4b258cda0e4b77/PerformanceTests/JetStream2/JetStreamDriver.js#L514
JS3: https://github.com/WebKit/WebKit/blob/ec6f02c2f3242338888639458e4b258cda0e4b77/PerformanceTests/JetStream3/JetStreamDriver.js#L514

This isn't an issue at the moment, since somehow the twistd server that run-benchmarks is using is able to work around the typo, but if we ever switch to a different HTTP server implementation (https://bugs.webkit.org/show_bug.cgi?id=259835), this will probably come back to bite us. We should fix this - or even better, switch to using XHR like we patch Speedometer and MotionMark to do: https://github.com/WebKit/WebKit/blob/ec6f02c2f3242338888639458e4b258cda0e4b77/Tools/Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch#L60
Comment 1 Radar WebKit Bug Importer 2023-08-18 17:36:14 PDT 
<rdar://problem/114116489>