WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
260104
AX: Test style cleanup for aria-current.html
https://bugs.webkit.org/show_bug.cgi?id=260104
Summary
AX: Test style cleanup for aria-current.html
Joshua Hoffman
Reported
2023-08-11 15:45:54 PDT
Adjust the test style of aria-current to be more consistent with other AX tests.
Attachments
Patch
(3.66 KB, patch)
2023-08-11 15:51 PDT
,
Joshua Hoffman
no flags
Details
Formatted Diff
Diff
Patch
(3.64 KB, patch)
2023-08-14 15:09 PDT
,
Joshua Hoffman
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-08-11 15:46:05 PDT
<
rdar://problem/113775205
>
Joshua Hoffman
Comment 2
2023-08-11 15:51:03 PDT
Created
attachment 467249
[details]
Patch
Andres Gonzalez
Comment 3
2023-08-14 06:44:22 PDT
(In reply to Joshua Hoffman from
comment #2
)
> Created
attachment 467249
[details]
> Patch
Thanks Josh. One more style guideline and we are there. Use JS templete strings instead of concatenation, e.g.: - output += "PASS: AXARIACurrent is " + value + "\n"; + output += `PASS: AXARIACurrent is ${value}\n`;
Joshua Hoffman
Comment 4
2023-08-14 15:09:53 PDT
Created
attachment 467273
[details]
Patch
EWS
Comment 5
2023-08-15 09:18:19 PDT
Committed
266913@main
(bb3bc0cc2777): <
https://commits.webkit.org/266913@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 467273
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug