Bug 260074 – Updates special case for flex-box emulating webkit-box

• Status: NEW
• Component: Layout and Rendering

[Ahmad Saleem]

Hi Team,

Came across another potential merge:

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/1874250

Failing Test Case: https://wpt.fyi/results/compat/webkit-box-fieldset.html?label=experimental&label=master&aligned

WPT Live Link: http://wpt.live/compat/webkit-box-fieldset.html

In local build, doing following change leads to test progressing. So I think it is good win.

Thanks!

[Ahmad Saleem]

Expected to fail, but passed: (2)
  imported/w3c/web-platform-tests/compat/webkit-box-fieldset.html
  imported/w3c/web-platform-tests/compat/webkit-box-rtl-flex.html


Regressions: Unexpected text-only failures (1)
  imported/w3c/web-platform-tests/compat/webkit-box-vertically-centered.html [ Failure ]

____

While running it on 'Compat' directory of WPT test cases.

[Radar WebKit Bug Importer]

<rdar://problem/114094538>

[Ahmad Saleem]

Tried this but didn't work:

if ((parent()->isDeprecatedFlexibleBox() || (parent()->isFlexibleBox() && (parent()->style().display() == DisplayType::Box ||  parent()->style().display() == DisplayType::InlineBox))) && (parent()->style().boxOrient() == BoxOrient::Horizontal || parent()->style().boxAlign() != BoxAlignment::Stretch))

[Karl Dubost]

What is happening here

Safari
FIELDSET: 966 x 10 (px)
  DIV:      0 x 10 (px)

Firefox, Chrome
FIELDSET: 966 x 10 (px)
  DIV:    966 x 10 (px)

I wonder if it's partly related to 
https://github.com/WebKit/WebKit/blob/509e7900b3d9d995f089ad54ee3e813d0f1086ef/Source/WebCore/rendering/RenderBlock.cpp#L3194

void RenderBlock::layoutExcludedChildren(bool relayoutChildren) {}
which has a lot of rules for Fieldset

[Ahmad Saleem]

(In reply to Ahmad Saleem from comment #1)
> Expected to fail, but passed: (2)
>   imported/w3c/web-platform-tests/compat/webkit-box-fieldset.html
>   imported/w3c/web-platform-tests/compat/webkit-box-rtl-flex.html
> 
> 
> Regressions: Unexpected text-only failures (1)
>   imported/w3c/web-platform-tests/compat/webkit-box-vertically-centered.html
> [ Failure ]
> 
> ____
> 
> While running it on 'Compat' directory of WPT test cases.

Just to flag, this is because of following:

if (parent()->isRenderFlexibleBox() && (parent()->style().boxOrient() == BoxOrient::Horizontal || parent()->style().boxAlign() != BoxAlignment::Stretch))

[Karl Dubost]

yes I tried to play with it a bit yesterday without success.