Bug 26004 - postMessage origin should follow lexical scope
Summary: postMessage origin should follow lexical scope
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-05-24 23:58 PDT by Adam Barth
Modified: 2009-06-03 16:48 PDT (History)
2 users (show)

See Also:


Attachments
patch (8.15 KB, patch)
2009-05-25 00:04 PDT, Adam Barth
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-05-24 23:58:15 PDT
postMessage origin should follow lexical scope, but it's currently using the dynamic scope.  Patch forthcoming.
Comment 1 Adam Barth 2009-05-25 00:04:34 PDT
Created attachment 30643 [details]
patch

I even remembered to link to the bug.
Comment 2 Maciej Stachowiak 2009-05-25 00:48:14 PDT
Comment on attachment 30643 [details]
patch

r=me

I'm not 100% sure of the v8 part but it looks close enough to me. Also I am surprised that setting document.domain to "0.0.1" works - that's probably a bug.
Comment 3 Adam Barth 2009-05-25 01:59:58 PDT
Fixed in r44124.
Comment 4 David Kilzer (:ddkilzer) 2009-05-26 06:20:40 PDT
<rdar://problem/6921231>
Comment 5 David Kilzer (:ddkilzer) 2009-06-03 16:48:27 PDT
(In reply to comment #3)
> Fixed in r44124.

<http://trac.webkit.org/changeset/44124>
ChangeLog typo fixed:  <http://trac.webkit.org/changeset/44125>
Follow-up layout test fix:  <http://trac.webkit.org/changeset/44133>
Follow-up layout test fix #2:  <http://trac.webkit.org/changeset/44134>